Make kube-proxy's MetricsBindAddress configurable via flag #48625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks! /assign @thockin |
|
/approve |
k8s-github-robot
added
the
approved
MrHohn
force-pushed
the
kube-proxy-metrics-flags
branch
from
6d45fd0
to
a4e359a
Compare
k8s-github-robot
removed
the
lgtm
|
Sorry, updated bazel BUILD files. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, ncdc, thockin Associated issue: 48600 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test pull-kubernetes-e2e-kops-aws |
|
Automatic merge from submit-queue (batch tested with PRs 47232, 48625, 48613, 48567, 39173) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jul 31, 2017
…-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #48625 Cherry pick of #48625 on release-1.7. #48625: Make kube-proxy's MetricsBindAddress configurable via flag **Release note**: ```release-note The IP address and port for kube-proxy metrics server is now configurable via flag `--metrics-bind-address` Special notice for kube-proxy in 1.7+ (including 1.7.0): - Healthz server (/healthz) will be served on 0.0.0.0:10256 by default. - Metrics server (/metrics and /proxyMode) will be served on 127.0.0.1:10249 by default. - Metrics server will continue serving /healthz. ```
|
/release-note |
k8s-ci-robot
added
release-note
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 3, 2017
Automatic merge from submit-queue Add kube-proxy change notice to v1.7.3 release note **What this PR does / why we need it**: Add necessary release note for issue #48600. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48600 **Special notes for your reviewer**: This is suppose to be in v1.7.3 release note, but turned out I only updated release note on the cherrypick PR (#49799) instead of the original PR (#48625) so nothing got picked up :( /assign @bowei @wojtek-t **Release note**: ```release-note NONE ```
|
It seems like the reference configuration is missing the |
2 tasks
|
@alexbrand Thanks for reporting. I opened kubernetes/website#5618 for tracking. |
|
Awesome! Thanks @MrHohn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: From #48600,
MetricsBindAddressused to be configurable through flag (coupled withHealthzBindAddress). But this functionality went away after #44968 separated healthz server from metrics server. This PR adds that functionality back.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):Special notes for your reviewer:
/assign @ncdc
cc @bowei @r0bj
Release note: