Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a regression test for Audit-ID http header #48693

Merged
merged 1 commit into from
Jul 12, 2017
Merged

add a regression test for Audit-ID http header #48693

merged 1 commit into from
Jul 12, 2017

Conversation

CaoShuFeng
Copy link
Contributor

This change add a test for: #48492

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @CaoShuFeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 10, 2017
@CaoShuFeng CaoShuFeng mentioned this pull request Jul 10, 2017
Merged
@sttts
Copy link
Contributor

sttts commented Jul 10, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017
@sttts
Copy link
Contributor

sttts commented Jul 10, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2017
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-unit

@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce
/test pull-kubernetes-unit

@sttts
Copy link
Contributor

sttts commented Jul 10, 2017

@CaoShuFeng: please rebase

@CaoShuFeng
Copy link
Contributor Author

@sttts
Rebased.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@sttts
Copy link
Contributor

sttts commented Jul 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoShuFeng, sttts

Associated issue requirement bypassed by: sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce
/test pull-kubernetes-e2e-kops-aws

@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@fejta
Copy link
Contributor

fejta commented Jul 11, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47948, 48631, 48693, 48549, 47593)

@k8s-github-robot k8s-github-robot merged commit 7b650c9 into kubernetes:master Jul 12, 2017
@CaoShuFeng CaoShuFeng deleted the audit_id_header branch November 6, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

@sttts sttts

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@CaoShuFeng @k8s-ci-robot @sttts @k8s-github-robot @fejta @soltysh @deads2k