Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #48915 #48946

Merged
merged 1 commit into from Jul 17, 2017
Merged

Automated cherry pick of #48915 #48946

merged 1 commit into from Jul 17, 2017

Conversation

mattmoyer
Copy link
Contributor

Cherry pick of #48915 on release-1.7.

#48915: kubeadm: fix broken kubeadm init --config flag.

@mattmoyer
kubeadm: fix broken kubeadm init --config flag.
aaf699d 
This code was changed in ea19649 to validate that `--config` wasn't passed along with other flags. Unfortunately, the implementation was checking `PersistentFlags()`, which was not parsed at the point it was being validated. The result was that `--config` was _always_ rejected, not just when it was specified alongside other flags.

The fix is to use `Flags()` instead, which contains the expected data.
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mattmoyer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2017
@luxas
Copy link
Member

luxas commented Jul 14, 2017

/lgtm
/ok-to-test
cc @wojtek-t ref: #48915

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, mattmoyer

Associated issue: 48915

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 14, 2017
@k8s-github-robot k8s-github-robot added this to the v1.7 milestone Jul 14, 2017
@wojtek-t
Copy link
Member

approve - just please don't remove "do-not-merge" label for now.

@mattmoyer mattmoyer mentioned this pull request Jul 17, 2017
Closed
@wojtek-t
Copy link
Member

OK - this is good to go. Removing do-not-merge label.

@wojtek-t wojtek-t removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 17, 2017
@wojtek-t
Copy link
Member

@kubernetes/test-infra-maintainers @fejta - those failures seem like infrastructure failures - can you please take a look?

@wojtek-t
Copy link
Member

@spxtr ^^

@spxtr
Copy link
Contributor

spxtr commented Jul 17, 2017

/assign @fejta

@krzyzacy
Copy link
Member

Your "OAuth 2.0 Service Account" credentials are invalid I thought we hit this before.. Can't remember what was the solution.

@spxtr
Copy link
Contributor

spxtr commented Jul 17, 2017

/unassign @fejta
/assign @ixdy

@k8s-ci-robot k8s-ci-robot assigned ixdy and unassigned fejta Jul 17, 2017
@fejta
Copy link
Contributor

fejta commented Jul 17, 2017

This makes me think there is a gsutil bug: I0717 18:26:40.008] Type position out of range

@wojtek-t
Copy link
Member

It seems that those tests are passing on other PRs in 1.7 branch. I will try retesting.

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2e4bb9a into kubernetes:release-1.7 Jul 17, 2017
@mattmoyer mattmoyer deleted the automated-cherry-pick-of-#48915-upstream-release-1.7 branch July 17, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@luxas luxas

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mattmoyer @k8s-ci-robot @luxas @k8s-github-robot @wojtek-t @spxtr @krzyzacy @fejta @justinsb @ixdy