-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #49125 #49327
Automated cherry pick of #49125 #49327
Conversation
GKE created clusters don't provide a MasterName, so don't throw a warning and give up when that happens.
Hi @abgworrall. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks) |
/unassign |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abgworrall, rmmh Assign the PR to them by writing Associated issue: 49125 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test pull-kubernetes-e2e-gce-etcd3 |
@abgworrall: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @zmerlynn |
/ok-to-test |
Automatic merge from submit-queue |
When testing, GKE created clusters don't provide a
MasterName
, so carry on anyway and log node OS images without itBackground: this is code that runs during gce/gke testing, and records which specific OS images were being run on the master and node. When we test new OS images for GKE, we need to test them on all supported branches (i.e. >=1.5), so this piece of work needs to be backported to all branches. This specific cherrypick adds a guard for GKE-created clusters, which omit the
MasterName
, letting it proceed and log the node OS.Cherry pick of #49125 on release-1.6.
#49125: Tolerate a missing MasterName (for GKE)