Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gce: extend CLOBBER_CONFIG to support known_tokens.csv #49898

Merged
merged 1 commit into from
Aug 2, 2017
Merged

gce: extend CLOBBER_CONFIG to support known_tokens.csv #49898

merged 1 commit into from
Aug 2, 2017

Conversation

mikedanese
Copy link
Member

Helps with #49895

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 31, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 31, 2017
@cjcullen
Copy link
Member

@liggitt FYI

@cjcullen
Copy link
Member

I think it is reasonable to extend the meaning of the recently introduced METADATA_CLOBBERS_CONFIG variable to include the tokens file.

@cjcullen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjcullen, mikedanese

Associated issue: 49895

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Jul 31, 2017

Sure, the concern was always about things depending on existing on disk config. If metadata is authoritative, it's authoritative.

@mikedanese mikedanese added this to the v1.7 milestone Aug 1, 2017
This was referenced Aug 1, 2017
Merged
Merged
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)

@k8s-github-robot k8s-github-robot merged commit d79c8fe into kubernetes:master Aug 2, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 2, 2017 •
edited

@mikedanese: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws a120906 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce-etcd3 a120906 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese mikedanese deleted the clober-tokens branch August 2, 2017 02:05
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 2, 2017
k8s-github-robot pushed a commit that referenced this pull request Aug 2, 2017
Merge pull request #49968 from mikedanese/automated-cherry-pick-of-#4…
07834b8 
…9897-#49898-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49897 #49898 release 1.7

Cherrypick of  #49897 #49898
Part of #49895
```release-note
In GCE, add measures to prevent corruption of known_tokens.csv
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Aug 5, 2017
Merge pull request #49969 from mikedanese/automated-cherry-pick-of-#4…
b6aa79e 
…9897-#49898-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #49897 #49898 release 1.6

Cherrypick of  #49897 #49898
Part of #49895
```release-note
In GCE, add measures to prevent corruption of known_tokens.csv
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ikehz ikehz

@cjcullen cjcullen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mikedanese @cjcullen @k8s-github-robot @liggitt @k8s-ci-robot @k8s-cherrypick-bot @ikehz @wojtek-t