Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #49992 #50017

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Automated cherry pick of #49992 #50017

merged 1 commit into from
Aug 4, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 2, 2017 •
edited

Cherry pick of #49992 on release-1.6.

#49992: Correctly handle empty watch event cache

Fixed a bug in the API server watch cache, which could cause a missing watch event immediately after cache initialization.

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 2, 2017
@liggitt liggitt assigned wojtek-t and enisoc and unassigned timothysc and ingvagabund Aug 2, 2017
@liggitt
Copy link
Member Author

liggitt commented Aug 2, 2017

@wojtek-t for review, @enisoc for release branch cherrypick approval

@wojtek-t
Copy link
Member

wojtek-t commented Aug 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2017
@wojtek-t wojtek-t added this to the v1.6 milestone Aug 4, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Aug 4, 2017

@enisoc - friendly ping for approval

@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 4, 2017
@enisoc
Copy link
Member

enisoc commented Aug 4, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, liggitt, wojtek-t

Associated issue: 49992

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d89d642 into kubernetes:release-1.6 Aug 4, 2017
@liggitt liggitt deleted the automated-cherry-pick-of-#49992-upstream-release-1.6 branch February 15, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @k8s-github-robot @wojtek-t @enisoc @timothysc @ingvagabund @k8s-ci-robot