Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should use time.Since instead of time.Now().Sub #50989

Merged
merged 1 commit into from
Sep 23, 2017
Merged

should use time.Since instead of time.Now().Sub #50989

merged 1 commit into from
Sep 23, 2017

Conversation

wgliang
Copy link
Contributor

@wgliang wgliang commented Aug 21, 2017

What this PR does / why we need it:

should use time.Since instead of time.Now().Sub

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
NONE
Special notes for your reviewer:
NONE
Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Hi @wgliang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 21, 2017
@dims
Copy link
Member

dims commented Aug 25, 2017

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-label-needed labels Aug 25, 2017
@wgliang
Copy link
Contributor Author

wgliang commented Aug 25, 2017

/retest

@wgliang
Copy link
Contributor Author

wgliang commented Aug 26, 2017

Who will add lgtm label?

@wgliang
Copy link
Contributor Author

wgliang commented Aug 26, 2017

/assign @dims

@dims
Copy link
Member

dims commented Aug 26, 2017

@wgliang i can only review, lgtm has to be one of the approvers in the pkg/controller/deployment/OWNERS file

@dims
Copy link
Member

dims commented Aug 26, 2017

/approve

@wgliang
Copy link
Contributor Author

wgliang commented Aug 26, 2017

/assign @Kargakis @mwielgus

@wgliang
Copy link
Contributor Author

wgliang commented Aug 28, 2017

/assign @Kargakis

@dims
Copy link
Member

dims commented Aug 31, 2017

/test all

@wgliang
Copy link
Contributor Author

wgliang commented Aug 31, 2017

/retest

1 similar comment
@wgliang
Copy link
Contributor Author

wgliang commented Sep 1, 2017

/retest

@wgliang
Copy link
Contributor Author

wgliang commented Sep 1, 2017

Why need lgtm again? @dims

@dims
Copy link
Member

dims commented Sep 1, 2017

Sorry i meant "you need approval from those in the OWNERS file, as i am not there my approval does not help"

@wgliang
Copy link
Contributor Author

wgliang commented Sep 1, 2017

/approve

@wgliang
Copy link
Contributor Author

wgliang commented Sep 1, 2017

/assign @janetkuo @nikhiljindal @Kargakis @mwielgus

@dims
Copy link
Member

dims commented Sep 1, 2017

/unassign dims

janetkuo
janetkuo approved these changes Sep 3, 2017
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you squash commits into one?

@wgliang
Copy link
Contributor Author

wgliang commented Sep 4, 2017 •
edited

Will multiple commits affect the merger? what should I do? Re-raised a PR？

@aleksandra-malinowska
Copy link
Contributor

@wgliang Just squash commits and force push to this branch. It will be the same PR, but approve and lgtm labels will have to be added again

@wgliang
Copy link
Contributor Author

wgliang commented Sep 4, 2017

I have squash commits and force push to this branch.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2017
@aleksandra-malinowska
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2017
@wgliang
Copy link
Contributor Author

wgliang commented Sep 5, 2017

/retest

@wgliang
Copy link
Contributor Author

wgliang commented Sep 5, 2017

How to solve the test failed? It was not my change.

@janetkuo
Copy link
Member

janetkuo commented Sep 5, 2017

/retest

@janetkuo
Copy link
Member

janetkuo commented Sep 5, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, dims, janetkuo, kargakis, wgliang

Associated issue requirement bypassed by: janetkuo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@0xmichalis 0xmichalis removed their assignment Sep 9, 2017
@wgliang
Copy link
Contributor Author

wgliang commented Sep 11, 2017

Who will have to review？

@mwielgus mwielgus removed their assignment Sep 12, 2017
@wgliang
Copy link
Contributor Author

wgliang commented Sep 14, 2017

@janetkuo

@wgliang
Copy link
Contributor Author

wgliang commented Sep 14, 2017

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@wgliang
Copy link
Contributor Author

wgliang commented Sep 17, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit ec382f3 into kubernetes:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@mfojtik mfojtik

@bskiba bskiba

@janetkuo janetkuo

@aleksandra-malinowska aleksandra-malinowska

@nikhiljindal nikhiljindal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet