Add debugging to the codegen process #51058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thockin
added
the
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
kind/api-change
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
the
needs-rebase
|
/retest |
|
@ixdy - this should be a relatively easy one, despite the scary name. |
ixdy
reviewed
Aug 30, 2017
| @@ -23,8 +23,6 @@ package unversioned | |||
| // TypeMeta describes an individual object in an API response or request | |||
| // with strings representing the type of the object and its API schema version. | |||
| // Structures that are versioned or persisted should inline TypeMeta. | |||
| // | |||
| // +k8s:deepcopy-gen=false | |||
There was a problem hiding this comment.
Yes, they cause spurious rebuilds but generate no output (so the dep is never satisfied).
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ixdy
removed
the
kind/api-change
k8s-github-robot
added
the
kind/api-change
|
ping |
|
/retest |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, thockin Associated issue requirement bypassed by: thockin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 51666, 49829, 51058, 51004, 50938) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was useful when debugging a different problem.