Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kubeproxy to work for Windows Kernel mode #51064

Merged
merged 4 commits into from
Sep 20, 2017
Merged

Fix Kubeproxy to work for Windows Kernel mode #51064

merged 4 commits into from
Sep 20, 2017

Conversation

madhanrm
Copy link
Contributor

@madhanrm madhanrm commented Aug 22, 2017 •
edited

What this PR does / why we need it:
Kubeproxy doenst work for with windows kernel mode. This PR adds a Kernel Proxy for windows to use the underlying platform features.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#49666
Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @madhanrm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Aug 22, 2017
@freehan
Copy link
Contributor

freehan commented Aug 22, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2017
@dineshgovindasamy
Copy link

Tagging @jdumars for FYI

@jdumars
Copy link
Member

jdumars commented Aug 23, 2017

/sig node
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 23, 2017
@jdumars
Copy link
Member

jdumars commented Aug 23, 2017

/cc @mikedanese

@jdumars jdumars mentioned this pull request Aug 24, 2017
Merged
@JMesser81
Copy link

@freehan - let's discuss at next sig-network meeting. We believe this is a low risk change which does not affect Linux at all or current Windows implementations using OVN or Apprenda solution.

@madhanrm madhanrm force-pushed the winkernelproxy branch 2 times, most recently from 8a50167 to e65d663 Compare August 25, 2017 06:03
@aserdean
Copy link
Contributor

(this is not a technical review)

Please break: 6e6d132 into
smaller commits, as described in https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#6-squashing-and-commit-titles.
It makes it easier for other people to review it and understand your logic
behind the changes.

Please add relevant commit messages to each individual commit, it helps
other people understand how you are trying to achieve your goal and of
course keep track of the evolution of the code.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2017
@jdumars
Copy link
Member

jdumars commented Aug 28, 2017

/cc @thockin

@mikedanese mikedanese assigned bowei and thockin and unassigned lavalamp Aug 28, 2017
@madhanrm
Copy link
Contributor Author

/test pull-kubernetes-cross
/test pull-kubernetes-kubemark-e2e-gce
/test pull-kubernetes-e2e-gce-gpu
/test pull-kubernetes-bazel
/test pull-kubernetes-verify

@madhanrm
Add exception to golint check
a8d797a 
(*) Fix cleanup of NodePort resources. (*) Fix the logic to select existing policies

Fix review comment

Fix Bazel

Update GoDep License

Fix NodePort forwarding to target port

Fix Darwin Build break. +1

Implement IsCompatible to validate kernel support for kernel mode
@dims
Copy link
Member

dims commented Sep 18, 2017

/retest

1 similar comment
@madhanrm
Copy link
Contributor Author

/retest

@dims
Copy link
Member

dims commented Sep 19, 2017

/test all

@dims
Copy link
Member

dims commented Sep 19, 2017

@madhanrm Can you please check the test failures and get the tests go green? i am afraid this will miss the 1.8 boat otherwise

@dineshgovindasamy
Copy link

/retest

1 similar comment
@dineshgovindasamy
Copy link

/retest

@thockin
Copy link
Member

thockin commented Sep 20, 2017

Is this ready?

@dims
Copy link
Member

dims commented Sep 20, 2017

the kubeadm-gce is stuck in "job triggered", trying to get that to run

/test all

@dineshgovindasamy
Copy link

@dims @thockin i have tried multiple retest and Kubeadm-gce is not at all getting triggered. I see that job is failing across multiple PR's. How do we proceed?

@dims
Copy link
Member

dims commented Sep 20, 2017

@fejta @spiffxp any tips here?

@krzyzacy
Copy link
Member

kubernetes/test-infra#4649

but do you care about the kubeadm job on your PR? that's a non-blocking job.

@krzyzacy
Copy link
Member

If it's ready, ask for a lgtm label and this can be picked up by sq/get merged regardless of kubeadm presubmit.

@dims
Copy link
Member

dims commented Sep 20, 2017

Looks like @thockin applied lgtm at least 2 times... and it was rebased away. let me try doing that

/assign

@dims
Copy link
Member

dims commented Sep 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, madhanrm, thockin

Associated issue: 49666

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@BenTheElder
Copy link
Member

It looks like the kubeadm job failed and just never posted the status. /cc @luxas.
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/51064/pull-kubernetes-e2e-kubeadm-gce/7151/

@BenTheElder BenTheElder mentioned this pull request Sep 20, 2017
Closed
@dims
Copy link
Member

dims commented Sep 20, 2017

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51064, 52132). If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit a16a126 into kubernetes:master Sep 20, 2017
@gkudra-msft gkudra-msft mentioned this pull request Nov 29, 2017
Closed
@rjmorse rjmorse mentioned this pull request Jan 19, 2018
Closed
@bsteciuk bsteciuk mentioned this pull request Jan 31, 2018
Closed
@CriaHu CriaHu mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@bowei bowei bowei left review comments

@cmluciano cmluciano cmluciano left review comments

@thockin thockin thockin left review comments

@dcbw dcbw dcbw left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@dims dims

@bowei bowei

@freehan freehan

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet