Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: use fast docker_pull #51297

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Aug 24, 2017

What this PR does / why we need it: takes advantage of bazelbuild/rules_docker#71.

Faster builds = yay.

Release note:

NONE

/assign @Q-Lee @spxtr @mikedanese

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 24, 2017
@ixdy
Copy link
Member Author

ixdy commented Aug 24, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2017
@ixdy
Copy link
Member Author

ixdy commented Aug 24, 2017

/retest

@zhangxiaoyu-zidif
Copy link
Contributor

A flake test.
/cc @cblecker @xiangpengzhao
/test pull-kubernetes-unit

@zhangxiaoyu-zidif
Copy link
Contributor

/test pull-kubernetes-unit

@ixdy
Copy link
Member Author

ixdy commented Aug 25, 2017

/retest

@spxtr
Copy link
Contributor

spxtr commented Aug 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, spxtr

Associated issue requirement bypassed by: ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50889, 51347, 50582, 51297, 51264)

@k8s-github-robot k8s-github-robot merged commit 2616513 into kubernetes:master Aug 26, 2017
@ixdy ixdy deleted the bazel-fast-docker_pull branch May 15, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants