Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Plumb network & subnetwork to master #51725

Merged
merged 1 commit into from
Sep 3, 2017
Merged

GCE: Plumb network & subnetwork to master #51725

merged 1 commit into from
Sep 3, 2017

Conversation

nicksardo
Copy link
Contributor

Which issue this PR fixes *
Fixes #51714

/assign @bowei

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 31, 2017
@nicksardo
Copy link
Contributor Author

/assign @mikedanese

@nicksardo nicksardo mentioned this pull request Aug 31, 2017
Merged
bowei
bowei reviewed Aug 31, 2017
View reviewed changes
cluster/gce/util.sh Outdated
--regions=${REGION} \
--project=${PROJECT} \
--format='value(name)' 2>/dev/null)
echo "Found subnet for region ${REGION} in ${NETWORK}: ${NODE_SUBNETWORK}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to check for returning empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add one.

@bowei
Copy link
Member

bowei commented Sep 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@bowei
Copy link
Member

bowei commented Sep 1, 2017

/approve

1 similar comment
@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, mikedanese, nicksardo

Associated issue: 51714

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@freehan freehan added this to the v1.8 milestone Sep 1, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 3, 2017 •
edited

@nicksardo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 5060643 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51805, 51725, 50925, 51474, 51638)

@k8s-github-robot k8s-github-robot merged commit 9637f46 into kubernetes:master Sep 3, 2017
k8s-github-robot pushed a commit that referenced this pull request Sep 5, 2017
Merge pull request #51739 from nicksardo/gce-xpn-kubeup
6b8d558 
Automatic merge from submit-queue (batch tested with PRs 51739, 51762)

GCE: Separate the network's project from the rest of the project

**What this PR does / why we need it**:
PR allows the user to specify a different project for network resources during cluster turn-up. 

Depends on #51725
Fixes #51846
/assign @bowei

**Release note**:
```release-note
NONE
```
@nicksardo nicksardo deleted the gce-plumb-netvars branch January 12, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Loadbalancer creation for service failing in case of custom network
6 participants
@nicksardo @bowei @mikedanese @k8s-github-robot @k8s-ci-robot @freehan