Build controller roles/bindings on demand #51818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
k8s-github-robot
added
the
do-not-merge/release-note-label-needed
|
cc @kubernetes/sig-auth-pr-reviews |
k8s-ci-robot
added
the
sig/auth
liggitt
added
release-note-none
|
/approve no-issue |
k8s-github-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ericchiang
approved these changes
Sep 1, 2017
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, ericchiang, liggitt Associated issue requirement bypassed by: liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
ericchiang
added
the
priority/important-soon
|
Automatic merge from submit-queue (batch tested with PRs 51819, 51706, 51761, 51818, 51500) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we start to have alpha gated features that involve policy changes, we need to conditionally include roles/bindings in policy based on feature enablement.
Examples:
This moves the policy building from an init() func to be on demand, so that feature gates set at the point we set up the post-start reconcile take effect