Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable in configure-helper.sh #51988

Merged
merged 1 commit into from Sep 6, 2017
Merged

Fix unbound variable in configure-helper.sh #51988

merged 1 commit into from Sep 6, 2017

Conversation

zmerlynn
Copy link
Member

@zmerlynn zmerlynn commented Sep 5, 2017

This isn't plumbed yet on GKE, so results in an unbound variable.

NONE

@zmerlynn
Fix unbound variable in configure-helper.sh
bd86be4 
This isn't plumbed yet on GKE, so results in an unbound variable.
@zmerlynn zmerlynn requested a review from MrHohn September 5, 2017 23:25
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2017
@zmerlynn zmerlynn added this to the v1.8 milestone Sep 5, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 5, 2017
MrHohn
MrHohn approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2017
@zmerlynn
Copy link
Member Author

zmerlynn commented Sep 5, 2017

/test pull-kubernetes-e2e-gke

@zmerlynn
Copy link
Member Author

zmerlynn commented Sep 5, 2017

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@bowei
Copy link
Member

bowei commented Sep 5, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, bowei, zmerlynn

Associated issue requirement bypassed by: zmerlynn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zmerlynn
Copy link
Member Author

zmerlynn commented Sep 5, 2017

/test pull-kubernetes-unit

@zmerlynn
Copy link
Member Author

zmerlynn commented Sep 6, 2017

Ok, it looks like this PR is necessary but not sufficient to get GKE back on track.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2017 •
edited

@zmerlynn: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke bd86be4 link /test pull-kubernetes-e2e-gke
pull-kubernetes-e2e-kops-aws bd86be4 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51921, 51829, 51968, 51988, 51986)

@k8s-github-robot k8s-github-robot merged commit 5786904 into kubernetes:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

Assignees

@bowei bowei

@ethernetdan ethernetdan

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zmerlynn @bowei @k8s-github-robot @k8s-ci-robot @MrHohn @ethernetdan