Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODO: check for defaulting min-available #53047

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Remove TODO: check for defaulting min-available #53047

merged 1 commit into from
Nov 10, 2017

Conversation

yuexiao-wang
Copy link
Contributor

@yuexiao-wang yuexiao-wang commented Sep 26, 2017 •
edited

Signed-off-by: yuexiao-wang wang.yuexiao@zte.com.cn

What this PR does / why we need it:
Remove the default for min-available

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Release note:

kubectl create pdb will no longer set the min-available field by default.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yuexiao-wang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2017
@yuexiao-wang
Copy link
Contributor Author

/assign @deads2k

@yuexiao-wang yuexiao-wang changed the title Remove the check for defaulting min-available Remove the deprecated check for defaulting min-available Sep 26, 2017
@xiangpengzhao
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2017
spiffxp
spiffxp reviewed Sep 26, 2017
View reviewed changes
pkg/kubectl/pdb.go

// This behavior is intended for backward compatibility.
// TODO: remove in Kubernetes 1.8
fmt.Fprintln(os.Stderr, "Deprecated behavior in kubectl create pdb: Defaulting min-available to 1. "+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/53047/pull-kubernetes-e2e-kops-aws/50520

W0926 16:37:37.741] # k8s.io/kubernetes/pkg/kubectl
W0926 16:37:37.742] pkg/kubectl/pdb.go:21: imported and not used: "os"
W0926 16:37:49.206] !!! [0926 16:37:49] Call tree:
W0926 16:37:49.207] !!! [0926 16:37:49]  1: /go/src/k8s.io/kubernetes/hack/lib/golang.sh:720 kube::golang::build_binaries_for_platform(...)
W0926 16:37:49.209] !!! [0926 16:37:49]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
W0926 16:37:49.213] !!! [0926 16:37:49] Call tree:
W0926 16:37:49.215] !!! [0926 16:37:49]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
W0926 16:37:49.219] !!! [0926 16:37:49] Call tree:
W0926 16:37:49.221] !!! [0926 16:37:49]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)

need to remove the "os" import since you removed the only use of the package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it and Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yuexiao-wang
Remove the default for min-available
29a11be 
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2017
@yuexiao-wang
Copy link
Contributor Author

/retest

@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@yuexiao-wang yuexiao-wang mentioned this pull request Sep 27, 2017
Closed
@spiffxp
Copy link
Member

spiffxp commented Sep 27, 2017

/test pull-kubernetes-e2e-kops-aws

@yuexiao-wang
Copy link
Contributor Author

/cc @deads2k @ghodss

@yuexiao-wang
Copy link
Contributor Author

@spiffxp Thank you very much

@spiffxp
Copy link
Member

spiffxp commented Sep 28, 2017

/lgtm
but pinging @foxish since they added the original TODO

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2017
@yuexiao-wang
Copy link
Contributor Author

/retest

@yuexiao-wang
Copy link
Contributor Author

@foxish Any suggestion? Thanks.

@yuexiao-wang
Copy link
Contributor Author

@foxish Could you review this PR?

kow3ns
kow3ns reviewed Oct 11, 2017
View reviewed changes
Copy link
Member

@kow3ns kow3ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a better description in the release not please.

@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2017
@yuexiao-wang
Copy link
Contributor Author

@kow3ns Thanks for your review and it is update

@yuexiao-wang
Copy link
Contributor Author

@foxish Could I remove this TODO?

@yuexiao-wang
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@yuexiao-wang yuexiao-wang changed the title Remove the deprecated check for defaulting min-available Remove TODO: check for defaulting min-available Oct 16, 2017
@spiffxp
Copy link
Member

spiffxp commented Oct 24, 2017

/retest
@kubernetes/sig-cli-pr-reviews could someone with approval rights take a look at this? is this the right team to ping for such an ask?

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Oct 24, 2017
@yuexiao-wang
Copy link
Contributor Author

/retest

@mengqiy
Copy link
Member

mengqiy commented Nov 3, 2017

/assign @foxish

@foxish
Copy link
Contributor

foxish commented Nov 3, 2017

LGTM, but we should have a better release note for this. Something like:

kubectl create pdb will no longer set the min-available field by default.

@yuexiao-wang
Copy link
Contributor Author

/retest

@yuexiao-wang
Copy link
Contributor Author

@foxish Thanks for your suggestion. The release note is updated.
PTAL

@yuexiao-wang
Copy link
Contributor Author

Could you approve this PR?

@yuexiao-wang
Copy link
Contributor Author

@foxish PTAL

@xiangpengzhao
Copy link
Contributor

/retest

@yuexiao-wang
Copy link
Contributor Author

ping @foxish

@foxish
Copy link
Contributor

foxish commented Nov 8, 2017

/lgtm

@foxish
Copy link
Contributor

foxish commented Nov 8, 2017

cc/ @liggitt @kubernetes/sig-cli-maintainers for approval

@yuexiao-wang
Copy link
Contributor Author

@liggitt Could you approve this PR?

@liggitt
Copy link
Member

liggitt commented Nov 10, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxish, liggitt, spiffxp, yuexiao-wang

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53047, 54861, 55413, 55395, 55308). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1e091c2 into kubernetes:master Nov 10, 2017
@k8s-ci-robot
Copy link
Contributor

@yuexiao-wang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 29a11be link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuexiao-wang yuexiao-wang deleted the remove-deprecated branch November 11, 2017 07:33
@yuexiao-wang
Copy link
Contributor Author

@liggitt Thanks

@tengqm tengqm mentioned this pull request Nov 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@kow3ns kow3ns kow3ns left review comments

@deads2k deads2k Awaiting requested review from deads2k

@ghodss ghodss Awaiting requested review from ghodss

Assignees

@spiffxp spiffxp

@foxish foxish

@ghodss ghodss

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet