Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes 'rwx' permissions for global users #54581

Conversation

bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Oct 25, 2017

  • the tests make an assumption that the permissions on the /tmp dir have not
    been altered

Signed-off-by: Brenda Chan brchan@pivotal.io

What this PR does / why we need it:

This PR modifies a conformance test that checks the file permissions when the/tmp dir is mounted.

The current tests make an assumption that the permissions on the /tmp dir on the host system has not been altered. We removed the check that global users need rwx, so the tests now only check for dtrwxrwx

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): N/A

Special notes for your reviewer: N/A

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

@bsnchan: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @bsnchan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 25, 2017
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2017
@bsnchan
Copy link
Contributor Author

bsnchan commented Oct 25, 2017

/assign @rmmh

I've signed the CLA - let me know if you need anything else.

Thanks in advance!

@dims
Copy link
Member

dims commented Oct 26, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2017
- the tests make an assumption that the permissions on the /tmp dir have not been altered
@bsnchan bsnchan force-pushed the conformance_host_path_permissions branch from 5951197 to d7768e6 Compare November 1, 2017 13:21
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 1, 2017
@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 1, 2017

Hey @dims @rmmh - let me know if you need anything else.

Thanks!

@gregpatricio
Copy link

Hi. @dims is there anything we can help with to get this PR merged?

@dims
Copy link
Member

dims commented Nov 2, 2017

@gregpatricio you need approval/lgtm from @saad-ali and @rmmh . probably best to ping them on sig-storage channel. Or check the OWNERS file above to see if there are others you can try to get reviews from.

@idvoretskyi
Copy link
Member

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 3, 2017
@idvoretskyi
Copy link
Member

cc @kubernetes/sig-storage-pr-reviews

@saad-ali
Copy link
Member

saad-ali commented Nov 6, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2017
@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 6, 2017

/test pull-kubernetes-bazel-test

@bsnchan
Copy link
Contributor Author

bsnchan commented Nov 6, 2017

Hi @saad-ali,

It looks like one of the tests were flakey so I had to rerun the pull-kubernetes-bazel-test. Looks like all this PR needs is the approved label.

@saad-ali
Copy link
Member

saad-ali commented Nov 7, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsnchan, saad-ali

Associated issue requirement bypassed by: saad-ali

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@timothysc
Copy link
Member

/cc @jpbetz re: cherry pick for 1.8 conformance

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed cherrypick-candidate labels Nov 9, 2017
@bsnchan
Copy link
Contributor Author

bsnchan commented Dec 13, 2017

@jpbetz - any chance we can get this cherry picked in for 1.8.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants