Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #51985 #54809

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Automated cherry pick of #51985 #54809

merged 1 commit into from
Nov 1, 2017

Conversation

chakri-nelluri
Copy link
Contributor

Cherry pick of #51985 on release-1.6.

#51985: Fix volume remount on reboot

@k8s-ci-robot
Copy link
Contributor

@chakri-nelluri: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #51985.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@chakri-nelluri: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 30, 2017
@enisoc enisoc added this to the v1.6 milestone Oct 30, 2017
@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2017
@enisoc
Copy link
Member

enisoc commented Oct 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2017
@enisoc enisoc removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@kubernetes kubernetes deleted a comment from fejta-bot Oct 31, 2017
@enisoc
Copy link
Member

enisoc commented Oct 31, 2017

Sorry for the noise. I've removed lgtm until we can fix the underlying test-infra issue: kubernetes/test-infra#5280

@enisoc
Copy link
Member

enisoc commented Oct 31, 2017

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chakri-nelluri, enisoc
We suggest the following additional approver: saad-ali

Assign the PR to them by writing /assign @saad-ali in a comment when ready.

Associated issue: 51985

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a8cc80c into kubernetes:release-1.6 Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gnufied gnufied

@enisoc enisoc

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chakri-nelluri @k8s-ci-robot @enisoc @k8s-github-robot @gnufied @msau42