Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no node role label of new joining node #55232

Closed
KeithTt opened this issue Nov 7, 2017 · 5 comments
Closed

There is no node role label of new joining node #55232

KeithTt opened this issue Nov 7, 2017 · 5 comments
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@KeithTt
Copy link

KeithTt commented Nov 7, 2017

kube version: 1.8.2
docker version: 17.10.0-ce

# kubectl get node --show-labels
NAME      STATUS    ROLES     AGE       VERSION   LABELS
uy08-07   Ready     master    7h        v1.8.2    beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/hostname=uy08-07,node-role.kubernetes.io/master=
uy08-08   Ready     <none>    1h        v1.8.2    beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/hostname=uy08-08

The node role is <none> defaultly?

And I add a label manully like this:

# kubectl label node uy08-08 node-role.kubernetes.io/node=
node "uy08-08" labeled

# kubectl get node --show-labels
NAME      STATUS    ROLES     AGE       VERSION   LABELS
uy08-07   Ready     master    7h        v1.8.2    beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/hostname=uy08-07,node-role.kubernetes.io/master=
uy08-08   Ready     node      1h        v1.8.2    beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/hostname=uy08-08,node-role.kubernetes.io/node=

Is this a bug?

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 7, 2017
@k8s-github-robot
Copy link

@KeithTt
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list and label list.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@wackxu
Copy link
Contributor

wackxu commented Nov 7, 2017

kubeadm join command do not explicitly label the role of node, If it is needed, I can help fix it.

@liggitt
Copy link
Member

liggitt commented Nov 7, 2017

node roles are not yet defined in kubernetes. additionally, nodes should not start labeling themselves with roles (see kubernetes/community#911 for discussion of why labels should be applied to nodes, not self-applied by nodes)

if you would like to request a particular cluster setup tool like kubeadm add role labels to nodes, that feature request could be opened against that tool's repo (https://github.com/kubernetes/kubeadm/, https://github.com/kubernetes/kops/, etc)

@liggitt liggitt closed this as completed Nov 7, 2017
@tsunamireversal-zz
Copy link

tsunamireversal-zz commented Oct 23, 2018

I have same issue, I'm trying to understand...
Are you saying that we should manually label nodes as "master" if we want them to behave as master nodes after joining? That they won't do that by themselves? Or does this apply to anything but master nodes?

@kolikons
Copy link

might be useful https://github.com/kolikons/label-watch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

6 participants