Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #55262 #55266

Merged
merged 1 commit into from Nov 8, 2017
Merged

Automated cherry pick of #55262 #55266

merged 1 commit into from Nov 8, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 7, 2017

Cherry pick of #55262 on release-1.8.

#55262: Fix 'Schedulercache is corrupted' error

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liggitt
We suggest the following additional approver: davidopp

Assign the PR to them by writing /assign @davidopp in a comment when ready.

Associated issue: 55262

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 7, 2017
@liggitt liggitt added this to the v1.8 milestone Nov 7, 2017
@jpbetz jpbetz added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 7, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 7, 2017
@liggitt liggitt force-pushed the automated-cherry-pick-of-#55262-upstream-release-1.8 branch from 7592632 to 3879e31 Compare November 7, 2017 21:20
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@jpbetz jpbetz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@liggitt
Copy link
Member Author

liggitt commented Nov 7, 2017

fixed gofmt error

@liggitt liggitt force-pushed the automated-cherry-pick-of-#55262-upstream-release-1.8 branch from 3879e31 to 82208c0 Compare November 7, 2017 23:52
@liggitt
Copy link
Member Author

liggitt commented Nov 7, 2017

actually fixed gofmt error

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@jpbetz jpbetz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2017
@liggitt
Copy link
Member Author

liggitt commented Nov 8, 2017

/retest

@jpbetz
Copy link
Contributor

jpbetz commented Nov 8, 2017

According to prow logs, the last run of pull-kubernetes-verify was successful but for some reasons the status is still pending..

@jpbetz
Copy link
Contributor

jpbetz commented Nov 8, 2017

Manually merging this, since all remaining test passed:

Not sure what's going on with prow.

@jpbetz jpbetz merged commit 861dab5 into kubernetes:release-1.8 Nov 8, 2017
@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 82208c0 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the automated-cherry-pick-of-#55262-upstream-release-1.8 branch April 22, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jayunit100 jayunit100

@davidopp davidopp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-github-robot @jpbetz @k8s-ci-robot @jayunit100 @davidopp