Enhance label and taint documentation in kubectl #55274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@venezia can you squash the commits down to one? otherwise lgtm |
venezia
force-pushed
the
enhance_label_taint_docs
branch
from
1d8ad20
to
42ffe38
Compare
k8s-ci-robot
added
size/S
venezia
force-pushed
the
enhance_label_taint_docs
branch
from
42ffe38
to
cdd945a
Compare
k8s-ci-robot
added
size/XS
… clarified both key and value to labels can be 63 characters long
venezia
force-pushed
the
enhance_label_taint_docs
branch
from
cdd945a
to
53b3b5b
Compare
|
Done - thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @adohe |
|
/sig cli |
k8s-ci-robot
added
the
sig/cli
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, shiywang, venezia Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 55648, 55274, 54982, 51955, 55639). If you want to cherry-pick this change to another branch, please follow the instructions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds some language around how taint and label keys can have a domain + '/' in front of them. From the current documentation, it would seem like these are not allowed even though well known labels have them.
Also, it seemed unclear (to me) that both the label's key and value can be 63 characters long. I wanted to clarify this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):None
Special notes for your reviewer:
Phrasing of "DNS subdomain prefix and '/'" was copied from a validator's message ... I'm unsure if its the best wording, but wanted to be consistent with the validator.
Release note: