Add shyamjvs to test/OWNERS

[shyamjvs]

I've been reviewing quite some PRs recently and have reviewed many in the past. + I have >80 commits in this code path (git log test | grep "shyamjvs@google.com") touching various parts including e2e/framework, utils, perftype, kubemark, e2e fixes from other SIGs (mostly in regard of scalability).

/cc @gmarek @spiffxp @krzyzacy @kubernetes/sig-testing-misc

[k8s-ci-robot]

@shyamjvs: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@shyamjvs: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gmarek]

+1 on that, but I'd like to get a second approval from someone from @kubernetes/sig-testing-misc. @spiffxp?

[fejta]

/lgtm

[spiffxp]

What do you think about OWNERS files in the specific directories you mentioned rather than at the top level of test?

[spiffxp]

eg:

spiffxp@kthxbye:kubernetes (master %)$ for path in \
$(git log --follow --name-only --author="Shyam Jeedigunta" test | grep ^test | sort | uniq); do\
  dirname $path; \
done | uniq -c
   1 test/e2e
   1 test/e2e/apimachinery
   3 test/e2e/common
   3 test/e2e
   7 test/e2e/framework
   1 test/e2e/kubectl
   2 test/e2e/perf
   5 test/e2e/scalability
   3 test/kubemark
   1 test/kubemark/common
   1 test/kubemark
   1 test/kubemark/gce
   2 test/kubemark
   4 test/kubemark/resources
   4 test/kubemark/resources/manifests/addons/kubemark-rbac-bindings
   6 test/kubemark/resources/manifests
   1 test/kubemark/resources
   1 test/kubemark
   1 test/kubemark/skeleton
   2 test/kubemark
   1 test/utils

[shyamjvs]

They don't have individual owners files. For e.g e2e, e2e/framework. Seems like it's only the SIG directories that're having them.

[krzyzacy]

/retest

[krzyzacy]

lgtm, 😂 obviously our test-infra folks cannot approve for you here

[shyamjvs]

@fejta / @gmarek Could one of you /approve no-issue this?

[spiffxp]

/approve no-issue
I guess I'd rather not blow scope here, and I've seen you put in the time. But this does look a clear cut case of where we (collectively) should be adding new OWNERS files for the leaves, and taking people out of the test/ dir where possible. Now that you're getting added to test/OWNERS, you have the power to do this, so that you wouldn't get assigned to all PR's that touch test/*

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, shyamjvs, spiffxp

Associated issue requirement bypassed by: spiffxp

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• test/OWNERS [fejta,spiffxp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[shyamjvs]

Yup.. I agree :)

[fejta]

Aaron 100% agree with that instinct. Filed a bug to do this separately.

[shyamjvs]

/retest

[shyamjvs]

@fejta Any reason why you've removed the retest-not-required label?

[fejta]

Yes, please leave retest labels off PRs as it just slows down the overall merge rate as it invalidates batch merges.

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 55301, 55319, 54018, 55322, 55125). If you want to cherry-pick this change to another branch, please follow the instructions here.