Add extra-args configs to kubernetes-worker charm #55334
Conversation
k8s-ci-robot
added
release-note
|
/approve no-issue |
k8s-github-robot
added
the
approved
| kubelet_opts['experimental-nvidia-gpus'] = '1' | ||
| else: | ||
| hookenv.log('Adding --feature-gates=Accelerators=true to kubelet') | ||
| kubelet_opts['feature-gates'] = 'Accelerators=true' |
There was a problem hiding this comment.
I need to test that the GPU functionality still works with this change. I don't think our automated tests cover it.
There was a problem hiding this comment.
Tested with a GPU worker. This worked how I would expect, so we should be good.
|
/assign @ktsakalozos Can you review this please? This should fix the bug that our CI tests are failing on. Thanks! |
|
Less code, less room for bugs. +1 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynerva, ktsakalozos Associated issue requirement bypassed by: Cynerva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 55044, 55257, 55334). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
This adds
kubelet-extra-argsandproxy-extra-argsconfig options to the kubernetes-worker charm, which allow operators to pass arbitrary configuraton to the kubelet and kube-proxy services.This also fixes a bug where the equivalent config options on kubernetes-master (
api-extra-args,controller-manager-extra-args,scheduler-extra-args) don't remove arguments from the services when they are removed from the config.Release note: