Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in rbac setup in configure-helper.sh #55419

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Nov 9, 2017

Fixed a typo which was causing script to break while creating a GKE cluster.

Specifically, the line "setup-addon-manifests 'addons' 'rbac/legacy-kubelet-user-disabled' " was meant to refer to the directory cluster/addons/rbac/legacy-kubelet-user-disable. The extra "d" at the end of "disable" was causing the script to break.

Original PR: #53144

Release Note:

None

fixed a typo which was causing script to break while creating a GKE cluster.

Specifically, the line  "setup-addon-manifests "addons" "rbac/legacy-kubelet-user-disabled" was meant to refer to the directory cluster/addons/rbac/legacy-kubelet-user-disable. The extra "d" at the end of disable was causing the script to break.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2017
@rramkumar1
Copy link
Contributor Author

rramkumar1 commented Nov 9, 2017

/assign @mikedanese

I saw that you made the PR which had the typo so just want you to take a look to make sure what I did is okay

@mikedanese
Copy link
Member

Thanks!

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2017
@mikedanese mikedanese added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, rramkumar1

Associated issue requirement bypassed by: mikedanese

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2017
@rramkumar1
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: you can't request testing unless you are a kubernetes member.

In response to this:

/test pull-kubernetes-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiangpengzhao
Copy link
Contributor

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2017
@rohitagarwal003 rohitagarwal003 mentioned this pull request Nov 9, 2017
@mikedanese mikedanese added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/blocks-others labels Nov 9, 2017
@spiffxp
Copy link
Member

spiffxp commented Nov 9, 2017

will be watching to see if this fixes #55189

@enisoc
Copy link
Member

enisoc commented Nov 9, 2017

xref the original PR #53144

@rohitagarwal003
Copy link
Member

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55268, 55282, 55419, 48340, 54829). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 760974f into kubernetes:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants