Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use whitelisted test image in Docker live-restore node e2e test #55510

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Use whitelisted test image in Docker live-restore node e2e test #55510

merged 1 commit into from
Nov 11, 2017

Conversation

yguo0905
Copy link
Contributor

What this PR does / why we need it:

This PR fixes this test:

[k8s.io] Docker features [Feature:Docker] when live-restore is enabled [Serial] [Slow] [Disruptive] containers should not be disrupted when the daemon shuts down and restarts

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2enode-cosbeta-k8sdev-serial/1199#k8sio-docker-features-featuredocker-when-live-restore-is-enabled-serial-slow-disruptive-containers-should-not-be-disrupted-when-the-daemon-shuts-down-and-restarts

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

None

/assign @yujuhong

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2017
@yujuhong
Copy link
Contributor

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yguo0905, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2017
@yguo0905
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54460, 55258, 54858, 55506, 55510). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit dbcab6d into kubernetes:master Nov 11, 2017
@yguo0905 yguo0905 deleted the use-whitelisted-test-image branch November 14, 2017 02:02
@yguo0905 yguo0905 mentioned this pull request Nov 14, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2017
Merge pull request #55646 from yguo0905/automated-cherry-pick-of-#555…
a4438c2 
…10-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55510

Cherry pick of #55510 on release-1.8.

#55510: Use whitelisted test image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yguo0905 @yujuhong @k8s-github-robot @k8s-ci-robot