Ensure GCE AlphaFeatureGate initialized

[osoriano]

If no config file is specified for the controller-manager,
the GCE CloudConfig.AlphaFeatureGate property is not initialized.

This can cause a panic when checking for alpha features in the GCE
provider.

NONE 

Closes #55544

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dixudx]

Actually I would like to move these to Line 242.

[roberthbailey]

@dixudx - please ensure that you sign the CLA.

Also, moving that code to line 242 makes sense to me.

[dixudx]

@osoriano Please sign the CLA. Thanks.

[osoriano]

@dixudx I moved the AlphaFeatureGate initialization to its own block on line 242
Also, I signed the CLA, thanks

[dixudx]

Actually I mean,

featureMap := make(map[string]bool)
cloudConfig.AlphaFeatureGate = &AlphaFeatureGate{featureMap}
if configFile != nil {
   ...
   alphaFeatureGate, err := NewAlphaFeatureGate(configFile.Global.AlphaFeatures)
   if err != nil {
       ...
   } else {
     ...
     cloudConfig.AlphaFeatureGate = alphaFeatureGate
   }
   ...
}

[dixudx]

We don't need two blocks if configFile != nil.

Please also squash your commits. Thanks for your contribution.

[osoriano]

Ok, makes sense. I moved the code from the else block to line 242.

I redeployed and the LoadBalancer was created.

[roberthbailey]

/lgtm
/approve

[osoriano]

/assign @saad-ali

[cblecker]

/ok-to-test

[saad-ali]

/lgtm
/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osoriano, roberthbailey, saad-ali

Associated issue: 55544

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/providers/gce/OWNERS [saad-ali]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[jberkus]

/priority critical-urgent

/remove-priority important-soon

adjusting priorities for code freeze.

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Current

@krousey @osoriano @roberthbailey @saad-ali

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

• sig/storage: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 55545, 55548, 55815, 56136, 56185). If you want to cherry-pick this change to another branch, please follow the instructions here.