Extend apiserver testserver

[dhilipkumars]

What this PR does / why we need it:
Extend the test pkg of api-server a little bit so that it can be used by others
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
We wanted to use this test pkg while creating a new integration test fixture, the idea of starting the api-server without actually starting a proper etcd (integration etcd ) is very useful, if would be great to extend this for other usecases such as insecure mode too.

It will also be useful to get the working tmpdir returned so that we could store additional certs (such as service account public and private keys and kubeconf for this apiserver) if needed, which will be cleaned up automatically by the teardownFn when the api server is terminating.

Release note:

NONE

ref: #50144

[dhilipkumars]

cc: @sttts

[dhilipkumars]

/sig testing

[dhilipkumars]

/test pull-kubernetes-unit

[sttts]

Can we make a TestServer struct out of all the return values?

[sttts]

Please rebase onto #51685. I added a flags []string to control the config. I don't want to get any more logic in here in this func. Flags enforce that we mostly have an e2e setup as with a real kube-apiserver.

[dhilipkumars]

Okay i guess you mean i wait for the PR to be merged? before continuing to work on this? If i rebase now wont this PR also get all the commits #51685 as its still not in the master yet? (Apologies for the silly question i have not rebased from a PR to a PR before, just confused)

How about a struct with methods?

type TestServer struct {
         //All the return values
}

func (T *TestServer) Start(....)....
func (T *TestServer) StartTestServerOrDie(...)...
.
.
.

Okay?

If yes , I will update this PR to only make this pkg from set of functions to struct with methods along with updating all its invocations.

[sttts]

just the return values, not the inputs, i.e. also no methods.

IMO we should not add anything to the inputs anymore, but use the flags instead (as done in my PR). Everything else results in non-standard apiserver instances again which this whole machanism was trying to fix (compared to the situation we have in integration tests).

[dhilipkumars]

/test pull-kubernetes-unit

[ncdc]

/unassign
/assign @sttts

[dhilipkumars]

@sttts I have moved commits from #51685 to this one, i will have to apply your suggestions with respect to return values, right now trying to fix the CI.

[dhilipkumars]

FYI : @spiffxp , @dims

[dhilipkumars]

/test pull-kubernetes-unit

[dhilipkumars]

/test pull-kubernetes-unit

[dhilipkumars]

This test repetitively fails in spite of this PR not doing anything specific to scale api object, it also appears that this test takes more than 10 mins (600 sec ) in which case go test will bring it down and mark as failed.

I1116 15:27:33.032] FAIL	k8s.io/kubernetes/test/integration/scale	600.384s

more evidence

panic: test timed out after 10m0s

goroutine 2887 [running]:
testing.startAlarm.func1()
        /home/d/goroot/go/src/testing/testing.go:1145 +0xf9
created by time.goFunc
        /home/d/goroot/go/src/time/sleep.go:170 +0x44

goroutine 1 [chan receive, 10 minutes]:
testing.(*T).Run(0xc420baa000, 0x3dcc1a3, 0x15, 0x3ed9878, 0x485636)
        /home/d/goroot/go/src/testing/testing.go:790 +0x2fc
testing.runTests.func1(0xc420baa000)
        /home/d/goroot/go/src/testing/testing.go:1004 +0x64
testing.tRunner(0xc420baa000, 0xc420c91de0)
        /home/d/goroot/go/src/testing/testing.go:746 +0xd0
testing.runTests(0xc4202fc880, 0x9116220, 0x1, 0x1, 0x30)
        /home/d/goroot/go/src/testing/testing.go:1002 +0x2d8
testing.(*M).Run(0xc4225f1f18, 0xc420c91f70)
        /home/d/goroot/go/src/testing/testing.go:921 +0x111
main.main()
        k8s.io/kubernetes/test/integration/scale/_test/_testmain.go:44 +0xdb

[dhilipkumars]

/priority important-soon

/kind feature.

[dhilipkumars]

@sttts could you LGTM again please? i had to rebase.

[dhilipkumars]

/kind feature

[sttts]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhilipkumars, dims, sttts

Associated issue requirement bypassed by: sttts

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• cmd/kube-apiserver/OWNERS [sttts]
• test/OWNERS [sttts]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[dhilipkumars]

@kubernetes/kubernetes-milestone-maintainers could someone say the below please
/status approved-for-milestone

[k8s-ci-robot]

You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to add status labels.

[spiffxp]

/status approved-for-milestone

[spiffxp]

/status in-progress

[jberkus]

/priority critical-urgent

/remove-priority important-soon

adjusting priorities for code freeze

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Current

@dhilipkumars @mikedanese @sttts

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

• sig/testing: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/feature: New functionality.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 55545, 55548, 55815, 56136, 56185). If you want to cherry-pick this change to another branch, please follow the instructions here.