Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #55512 #55554

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Automated cherry pick of #55512 #55554

merged 1 commit into from
Nov 13, 2017
+17 −0

Conversation

dashpole
Copy link
Contributor

Cherry pick of #55512 on release-1.6.

#55512: allow configuring of the docker storage driver on gce

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 12, 2017
@yujuhong yujuhong assigned dchen1107 and enisoc and unassigned bowei and vishh Nov 13, 2017
@yujuhong yujuhong added this to the v1.6 milestone Nov 13, 2017
@abgworrall
Copy link
Contributor

/cc abgworrall

@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 13, 2017
@enisoc
Copy link
Member

enisoc commented Nov 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole, enisoc
We suggest the following additional approver: dchen1107

Assign the PR to them by writing /assign @dchen1107 in a comment when ready.

Associated issue: 55512

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dashpole
Copy link
Contributor Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d95894f into kubernetes:release-1.6 Nov 13, 2017
@dashpole dashpole deleted the automated-cherry-pick-of-#55512-upstream-release-1.6 branch November 13, 2017 20:27
@yujuhong yujuhong mentioned this pull request Nov 15, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 17, 2017
Merge pull request #55743 from kubernetes/revert-55554-automated-cher…
1085a36 
…ry-pick-of-#55512-upstream-release-1.6

Automatic merge from submit-queue.

Revert "Automated cherry pick of #55512"

Reverts #55554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgworrall abgworrall Awaiting requested review from abgworrall

Assignees

@enisoc enisoc

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dashpole @abgworrall @enisoc @k8s-github-robot @bowei @vishh @dchen1107 @yujuhong @k8s-ci-robot