Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtypo #55569

Merged
merged 1 commit into from
Nov 23, 2017
Merged

fixtypo #55569

merged 1 commit into from
Nov 23, 2017

Conversation

x1957
Copy link
Contributor

@x1957 x1957 commented Nov 13, 2017

What this PR does / why we need it:
fixtypo
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2017
@dims
Copy link
Member

dims commented Nov 13, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2017
@resouer
Copy link
Contributor

resouer commented Nov 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2017
@resouer
Copy link
Contributor

resouer commented Nov 14, 2017

/assign @timothysc

For approve.

@timothysc
Copy link
Member

/test pull-kubernetes-unit

@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2017
@timothysc timothysc added this to the v1.9 milestone Nov 22, 2017
@timothysc timothysc added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. status/approved-for-milestone priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 22, 2017
@timothysc timothysc added status/in-progress sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 22, 2017
@jberkus
Copy link

jberkus commented Nov 23, 2017

/lgtm

can we just merge this already? It's a typo, in a comment.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jberkus, resouer, x1957
We suggest the following additional approver: timothysc

Assign the PR to them by writing /assign @timothysc in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@jberkus @resouer @timothysc @x1957 @kubernetes/sig-scheduling-misc

Important: Code freeze is in effect and only pull requests with priority/critical-urgent may remain in the v1.9 milestone.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Nov 23, 2017
@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. retest-not-required labels Nov 23, 2017
@enisoc enisoc removed milestone/removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 23, 2017
@enisoc enisoc added this to the v1.9 milestone Nov 23, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4904037 into kubernetes:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jberkus jberkus

@timothysc timothysc

@resouer resouer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@x1957 @dims @resouer @timothysc @jberkus @k8s-github-robot @enisoc @k8s-ci-robot