-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug: without Unlock in error case, and remove unrelated test cases #55575
Conversation
/assign @sttts |
/cc @dixudx |
This bug is introduced by code not fully synced in my dev env. |
/ok-to-test |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, hzxuzhonghu, sttts Associated issue requirement bypassed by: sttts The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
/test pull-kubernetes-unit |
Automatic merge from submit-queue (batch tested with PRs 52148, 55575). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
fix bug in SafeWaitgroup without Unlock when Add error. And remove unrelated test cases.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: