Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipvs/proxy getLocalIPs inconsistency with iptables/proxy #55601

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

m1093782566
Copy link
Contributor

@m1093782566 m1093782566 commented Nov 13, 2017

What this PR does / why we need it:

  • Fix ipvs/proxy getLocalIPs() inconsistency with iptables/proxy

  • validate the ip address before pkg/proxy/util IPPart() return ip string.

Which issue(s) this PR fixes :
Fixes #55612

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2017
@k8s-ci-robot k8s-ci-robot assigned thockin and unassigned dcbw Nov 13, 2017
@m1093782566 m1093782566 changed the title Fix pkg/proxy getLocalIPs bug Fix ipvs/proxy getLocalIPs inconsistent with iptables/proxy Nov 13, 2017
@m1093782566 m1093782566 changed the title Fix ipvs/proxy getLocalIPs inconsistent with iptables/proxy Fix ipvs/proxy getLocalIPs inconsistency with iptables/proxy Nov 13, 2017
@m1093782566
Copy link
Contributor Author

@thockin

BTW, I still suggest a code refactor in kube-proxy, especially abstract the serviceInfo and endpointsInfo to reduce the huge code duplication between ipvs proxy and iptables proxy. By doing that, it can reduce the possibility of inconsistency as well.

@thockin
Copy link
Member

thockin commented Nov 13, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, thockin

Associated issue: 55612

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55009, 55532, 55601, 52569, 55533). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit cae7240 into kubernetes:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getLocalIPs() in pkg/proxy may return bad ip address
7 participants