Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node e2e: add a cloud-init script to disable live-restore in node e2e test #55639

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Node e2e: add a cloud-init script to disable live-restore in node e2e test #55639

merged 1 commit into from
Nov 15, 2017

Conversation

yguo0905
Copy link
Contributor

This cloud-init config will be used in tests in https://github.com/kubernetes/test-infra.

Release note:

None

/assign @yujuhong
/cc @abgworrall @dchen1107

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 13, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2017
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@dchen1107 dchen1107 changed the title Add a cloud-init script to set docker storage driver to overlay and disable live-restore Add a cloud-init script for node-e2e to set docker storage driver to overlay and disable live-restore Nov 14, 2017
@dchen1107
Copy link
Member

Updated the pr with explicitly claiming for node e2e.

/lgtm

@yguo0905
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@yujuhong
Copy link
Contributor

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2017
@yguo0905 yguo0905 changed the title Add a cloud-init script for node-e2e to set docker storage driver to overlay and disable live-restore Node e2e: add a cloud-init script to disable live-restore in node e2e test Nov 15, 2017
This was referenced Nov 15, 2017
Merged
Merged
Merged
yujuhong
yujuhong reviewed Nov 15, 2017
View reviewed changes
test/e2e_node/jenkins/cos-init-overlay-no-live-restore.yaml Outdated
@@ -0,0 +1,24 @@
#cloud-config
#
# This cloud-init configuration file sets Docker storage driver to 'overlay'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yujuhong
Copy link
Contributor

/retest

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yguo0905, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enisoc
Copy link
Member

enisoc commented Nov 15, 2017

Usually we'd want to minimize differences between test and prod to avoid hiding problems. I'm guessing you have a reason for making this a test-only change. Could someone document that here, or link to an issue where it's explained?

@yguo0905
Copy link
Contributor Author

We added an option to allow us to disable live-restore on GCE in #55260. We use this option in prod.

The node e2e tests do not use the cluster start script, so we need to create this cloud-init config to disable live-restore in node e2e tests.

@enisoc
Copy link
Member

enisoc commented Nov 15, 2017

@yguo0905 Makes sense. Thanks for the explanation.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55648, 55274, 54982, 51955, 55639). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a15fde4 into kubernetes:master Nov 15, 2017
@yguo0905 yguo0905 deleted the cloud-init branch November 15, 2017 21:14
k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2017
Merge pull request #55755 from yguo0905/automated-cherry-pick-of-#556…
c5e5c95 
…39-upstream-release-1.6

Automatic merge from submit-queue.

Automated cherry pick of #55639

Cherry pick of #55639 on release-1.6.

#55639: Add a cloud-init script to set docker storage driver to
@enisoc enisoc mentioned this pull request Nov 17, 2017
Closed
k8s-github-robot pushed a commit that referenced this pull request Nov 18, 2017
Merge pull request #55753 from yguo0905/automated-cherry-pick-of-#556…
db27b55 
…39-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #55639

Cherry pick of #55639 on release-1.8.

#55639: Add a cloud-init script to set docker storage driver to
k8s-github-robot pushed a commit that referenced this pull request Nov 21, 2017
Merge pull request #55754 from yguo0905/automated-cherry-pick-of-#556…
98c4504 
…39-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #55639

Cherry pick of #55639 on release-1.7.

#55639: Add a cloud-init script to set docker storage driver to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujuhong yujuhong yujuhong left review comments

@abgworrall abgworrall Awaiting requested review from abgworrall

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yguo0905 @yujuhong @dchen1107 @k8s-github-robot @enisoc @k8s-ci-robot