Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be less agressive and more patient when creating large master. #55794

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Be less agressive and more patient when creating large master. #55794

merged 1 commit into from
Nov 21, 2017

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

Workaround for #55777

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2017
@bowei
Copy link
Member

bowei commented Nov 16, 2017

Can you explain how this will address the linked issue? If the zone is out of quota, wouldn't waiting long not change anything?

@porridge
Copy link
Member Author

@bowei see #55777 (comment) - waiting actually did make a difference, because it's not so much about quota, as about binpacking the large master. In the background we're also working towards a better solution, but I think this workaround might be good enough for the time being.

bowei
bowei reviewed Nov 16, 2017
View reviewed changes
cluster/gce/gci/master-helper.sh Outdated
@@ -76,6 +76,12 @@ function replicate-master-instance() {
function create-master-instance-internal() {
local gcloud="gcloud"
local retries=5
local sleep_sec=10
if [[ "${MASTER_SIZE}" =~ -64$ ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the biggest MASTER_SIZE?
maybe?

local suffix=$( echo "${MASTER_SIZE}" | sed 's/.*-\([0-9]\+\)/\1' )
if [[ "${suffix}" -ge 64 ]]; then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this will be more robust.
Done.

@porridge
Copy link
Member Author

Rebased.

@porridge porridge mentioned this pull request Nov 16, 2017
Closed
@porridge
Copy link
Member Author

/retest
crossing fingers

@porridge
Copy link
Member Author

/test pull-kubernetes-e2e-gke-gci

@shyamjvs shyamjvs added this to the v1.9 milestone Nov 21, 2017
@shyamjvs
Copy link
Member

/kind bug
/priority important-soon
/sig scalability
(as this should reduce flakiness in release-blocking scalability jobs due to #55777 )

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Nov 21, 2017
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
@wojtek-t
Copy link
Member

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: porridge, wojtek-t

Associated issue: 55777

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@bowei @gmarek @porridge @wojtek-t

Note: If this pull request is not resolved or labeled as priority/critical-urgent by Wed, Nov 22 it will be moved out of the v1.9 milestone.

Pull Request Labels
  • sig/scalability: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@porridge
Copy link
Member Author

porridge commented Nov 21, 2017 via email

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54316, 53400, 55933, 55786, 55794). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a69f9da into kubernetes:master Nov 21, 2017
@porridge porridge deleted the patient-big-master branch December 28, 2017 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

@gmarek gmarek

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@porridge @bowei @shyamjvs @wojtek-t @k8s-github-robot @gmarek @k8s-ci-robot