Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call f.BeforeEach() again in ingress suite #56128

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Nov 21, 2017

What this PR does / why we need it: Calling f.BeforeEach() explicitly in ingress suite is causing test panics. See #56089.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes (hopefully) #56089

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2017
@MrHohn
Copy link
Member Author

MrHohn commented Nov 21, 2017

Ref #56089 (comment).

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2017
@BenTheElder
Copy link
Member

/priority failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 21, 2017
@BenTheElder
Copy link
Member

This should also hopefully fix #56080

@MrHohn
Copy link
Member Author

MrHohn commented Nov 21, 2017

/assign @bowei @spiffxp

@BenTheElder
Copy link
Member

This needs to be added to the milestone.
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2017
@abgworrall abgworrall added this to the v1.9 milestone Nov 21, 2017
@abgworrall abgworrall added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 21, 2017
@abgworrall
Copy link
Contributor

@bowei, can you status/approved-for-milestone this wearing your sig-network lead hat ?

@bowei
Copy link
Member

bowei commented Nov 21, 2017

@abgworrall -- I don't have the github perms...

@BenTheElder
Copy link
Member

BenTheElder commented Nov 21, 2017

@abgworrall you're in the right team you should be able to /status approved-for-milestone
the last command here, the team here.

@abgworrall
Copy link
Contributor

/status approved-for-milestone
I feel bad doing this on behalf of sig-network; but if bowei@ can't do that, then who can ...

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@MrHohn @bowei @caseydavenport @danwinship @spiffxp @kubernetes/sig-network-misc

Action required: During code slush, pull requests in the milestone should be in progress.
If this pull request is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight pull requests.

Note: This pull request is marked as priority/critical-urgent, and must be updated every 3 days during code slush.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/network: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@BenTheElder
Copy link
Member

@abgworrall perhaps we should get @bowei on the milestone maintainers team? this seems fine though since you're just doing it on his behalf anyhow 🤷‍♂️

@bowei
Copy link
Member

bowei commented Nov 21, 2017

I am looking into getting said hat.

@bowei
Copy link
Member

bowei commented Nov 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, MrHohn

Associated issue: 56089

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caseydavenport
Copy link
Member

fwiw, lgtm (and approved for milestone)

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@MrHohn
Copy link
Member Author

MrHohn commented Nov 22, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2ba1d99 into kubernetes:master Nov 22, 2017
@k8s-ci-robot
Copy link
Contributor

@MrHohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 11d283e link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/needs-attention priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants