-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call f.BeforeEach() again in ingress suite #56128
Don't call f.BeforeEach() again in ingress suite #56128
Conversation
Ref #56089 (comment). |
/priority failing-test |
This should also hopefully fix #56080 |
This needs to be added to the milestone. |
@bowei, can you |
@abgworrall -- I don't have the github perms... |
@abgworrall you're in the right team you should be able to |
/status approved-for-milestone |
[MILESTONENOTIFIER] Milestone Pull Request Needs Attention @MrHohn @bowei @caseydavenport @danwinship @spiffxp @kubernetes/sig-network-misc Action required: During code slush, pull requests in the milestone should be in progress. Note: This pull request is marked as Example update:
Pull Request Labels
|
@abgworrall perhaps we should get @bowei on the milestone maintainers team? this seems fine though since you're just doing it on his behalf anyhow 🤷♂️ |
I am looking into getting said hat. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, MrHohn Associated issue: 56089 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
fwiw, lgtm (and approved for milestone) |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@MrHohn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it: Calling f.BeforeEach() explicitly in ingress suite is causing test panics. See #56089.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes (hopefully) #56089
Special notes for your reviewer:
Release note: