Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix controlplane unit tests #56190

Merged
merged 2 commits into from
Nov 23, 2017
Merged

fix controlplane unit tests #56190

merged 2 commits into from
Nov 23, 2017

Conversation

edisonxiang
Copy link
Contributor

@edisonxiang edisonxiang commented Nov 22, 2017 •
edited

What this PR does / why we need it:

when the flexvolumeDirVolumePath is truely existent in the host,
cmd/kubeadm/app/phases/controlplane unit tests will be failed.

Fixes #56189

Release note:

NONE

@edisonxiang
fix controlplane unit tests
18f0802 
What this PR does / why we need it:

when the flexvolumeDirVolumePath is truely existent in the host,
```cmd/kubeadm/app/phases/controlplane``` unit tests will be failed.

Fixes kubernetes#56189

Release note:
```release-note
NONE
```
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2017
@edisonxiang
Copy link
Contributor Author

@dmmcquay @freeformz @luxas Welcome to review. Thanks.

@dixudx
Copy link
Member

dixudx commented Nov 22, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2017
@ChiuWang
Copy link
Contributor

It seems you need gofmt

@edisonxiang
Copy link
Contributor Author

@charrywanganthony, thanks.

@xiangpengzhao
Copy link
Contributor

/test pull-kubernetes-bazel-test
seems like it's a ❄️

luxas
luxas approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this contribution @edisonxiang!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edisonxiang, luxas

Associated issue: 56189

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@luxas luxas added this to the v1.9 milestone Nov 23, 2017
@luxas luxas added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/approved-for-milestone and removed milestone/incomplete-labels labels Nov 23, 2017
@luxas luxas added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/bug Categorizes issue or PR as related to a bug. labels Nov 23, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Needs Attention

@andrewrynhard @dmmcquay @edisonxiang @luxas @timothysc @kubernetes/sig-cluster-lifecycle-misc

Action Required: This pull request has not been updated since Nov 22. Please provide an update.

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/cluster-lifecycle: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 362e629 into kubernetes:master Nov 23, 2017
@edisonxiang
Copy link
Contributor Author

@luxas Thanks your approve:)

@edisonxiang edisonxiang deleted the fixcontrolplaneunittests branch January 30, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

Assignees

@timothysc timothysc

@dmmcquay dmmcquay

@andrewrynhard andrewrynhard

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/needs-attention priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@edisonxiang @dixudx @ChiuWang @xiangpengzhao @k8s-github-robot @luxas @timothysc @dmmcquay @andrewrynhard @k8s-ci-robot