Fix unit tests that need openstack

[dims]

What this PR does / why we need it:
Currently the unit tests that depend that they be on running inside an openstack vm fail as no one seem to have run them for a while.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
ref #56437

Special notes for your reviewer:

Release note:

NONE

[dims]

Here's what the output when running from my mac

[dims@dims-mac 15:34] ~/go/src/k8s.io/kubernetes ⟩ go test -v k8s.io/kubernetes/pkg/cloudprovider/providers/openstack
=== RUN   TestParseMetadata
--- PASS: TestParseMetadata (0.00s)
=== RUN   TestRoutes
--- PASS: TestRoutes (21.87s)
	openstack_routes_test.go:70: 10.164.2.0/24 via testvm-2
=== RUN   TestReadConfig
--- PASS: TestReadConfig (0.00s)
=== RUN   TestToAuthOptions
--- PASS: TestToAuthOptions (0.00s)
=== RUN   TestCheckOpenStackOpts
--- PASS: TestCheckOpenStackOpts (0.00s)
=== RUN   TestCaller
--- PASS: TestCaller (0.00s)
=== RUN   TestNodeAddresses
--- PASS: TestNodeAddresses (0.00s)
	openstack_test.go:362: addresses is [{InternalIP 10.0.0.31} {InternalIP 10.0.0.32} {ExternalIP 2001:4800:780e:510:be76:4eff:fe04:84a8} {ExternalIP 2001:4800:790e:510:be76:4eff:fe04:82a8} {ExternalIP 50.56.176.35} {ExternalIP 50.56.176.36} {ExternalIP 50.56.176.99}]
=== RUN   TestNewOpenStack
--- PASS: TestNewOpenStack (0.81s)
=== RUN   TestLoadBalancer
--- PASS: TestLoadBalancer (2.47s)
	openstack_test.go:450: Trying LBVersion = 'v2'
	openstack_test.go:450: Trying LBVersion = ''
=== RUN   TestZones
--- PASS: TestZones (0.00s)
=== RUN   TestVolumes
--- PASS: TestVolumes (34.38s)
	openstack_test.go:523: Volume (7ca2dac0-6928-438e-a74e-cd9d26d69854) created
	openstack_test.go:65: Volume (7ca2dac0-6928-438e-a74e-cd9d26d69854) status changed to available after 30 seconds
	openstack_test.go:529: Cannot find instance id: error fetching http://169.254.169.254/openstack/2012-08-10/meta_data.json: Get http://169.254.169.254/openstack/2012-08-10/meta_data.json: dial tcp 169.254.169.254:80: i/o timeout - perhaps you are running this test outside a VM launched by OpenStack
	openstack_test.go:558: Volume (7ca2dac0-6928-438e-a74e-cd9d26d69854) deleted
=== RUN   TestInstanceIDFromProviderID
--- PASS: TestInstanceIDFromProviderID (0.00s)
PASS
ok  	k8s.io/kubernetes/pkg/cloudprovider/providers/openstack	59.605s

[xsgordon]

/sig openstack

[FengyunPan]

LGTM, I have tested too.
/approve

[dims]

/kind bug

[dims]

@enisoc @jdumars - can we please mark this for 1.9? it just updates unit tests for openstack

[anguslees]

/lgtm

[dims]

@idvoretskyi can you please "/approve no-issue" and apply the milestone tag?

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, dims, FengyunPan

Associated issue: 56437

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/providers/openstack/OWNERS [FengyunPan,anguslees,dims]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request Current

@NickrenREN @anguslees @dims

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

• sig/openstack: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 56446, 56437). If you want to cherry-pick this change to another branch, please follow the instructions here.