Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cadvisor godep to v0.27.3 #56445

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Update cadvisor godep to v0.27.3 #56445

merged 1 commit into from
Nov 29, 2017

Conversation

dashpole
Copy link
Contributor

What this PR does / why we need it:
Update cadvisor version from v0.27.2 to v0.27.3.

Special notes for your reviewer:
cAdvisor keeps one branch for each cadvisor branch. The v0.27 branch tracks the kubernetes 1.8 branch.

Release note:

Update jquery and bootstrap dependencies

/assign @tallclair

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 27, 2017
@dashpole
Copy link
Contributor Author

/assign @dchen1107

@enisoc enisoc added this to the v1.8 milestone Nov 27, 2017
@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 27, 2017
@dashpole
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 27, 2017
@dashpole
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 27, 2017
@dashpole
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 27, 2017
@dashpole dashpole removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 27, 2017
@dashpole dashpole changed the title update cadvisor godep to v0.27.3 Update cadvisor godep to v0.27.3 Nov 27, 2017
tallclair
tallclair reviewed Nov 27, 2017
View reviewed changes
vendor/github.com/vishvananda/netns/BUILD Outdated
"@io_bazel_rules_go//go:def.bzl",
"go_library",
)
load("@io_bazel_rules_go//go:def.bzl", "go_library")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2017
@dchen1107
Copy link
Member

/lgtm

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, tallclair

Associated issue requirement bypassed by: dchen1107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enisoc enisoc added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 28, 2017
@dashpole dashpole removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 28, 2017
@tallclair
Copy link
Member

/assign @jpbetz

For cherry-pick approval.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@dashpole @dchen1107 @jpbetz @tallclair

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 29, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 43be4ee into kubernetes:release-1.8 Nov 29, 2017
@dashpole dashpole deleted the update_cadvisor_v0.27.3 branch November 29, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

Assignees

@jpbetz jpbetz

@dchen1107 dchen1107

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dashpole @tallclair @dchen1107 @k8s-github-robot @jpbetz @enisoc @k8s-ci-robot