Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking HPA_USE_REST_CLIENTS #56482

Merged
merged 1 commit into from Nov 29, 2017
Merged

Add checking HPA_USE_REST_CLIENTS #56482

merged 1 commit into from Nov 29, 2017

Conversation

aleksandra-malinowska
Copy link
Contributor

@aleksandra-malinowska aleksandra-malinowska commented Nov 28, 2017 •
edited

Add checking HPA_USE_REST_CLIENTS in addition to ENABLE_METRICS_SERVER when disabling REST clients use for HPA.

NONE

@aleksandra-malinowska aleksandra-malinowska added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Nov 28, 2017
@aleksandra-malinowska aleksandra-malinowska added this to the v1.9 milestone Nov 28, 2017
@aleksandra-malinowska aleksandra-malinowska self-assigned this Nov 28, 2017
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 28, 2017
@aleksandra-malinowska aleksandra-malinowska added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2017
@gmarek
Copy link
Contributor

gmarek commented Nov 28, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@kawych
Copy link
Contributor

kawych commented Nov 28, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, gmarek, kawych

Associated issue requirement bypassed by: gmarek

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@aleksandra-malinowska
Copy link
Contributor Author

/retest

@aleksandra-malinowska
Copy link
Contributor Author

/retest

@enisoc
Copy link
Member

enisoc commented Nov 28, 2017

Is there an issue that describes why this is needed for 1.9.0?

@enisoc enisoc added the sig/gcp label Nov 29, 2017
@enisoc
Copy link
Member

enisoc commented Nov 29, 2017

I got a response offline from @aleksandra-malinowska that this is needed to make it possible to opt-out of using the (new in 1.9) metrics server, even if the metrics server is running.

@enisoc enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. status/in-progress and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 29, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@aleksandra-malinowska @enisoc @gmarek @kawych

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Pull Request Labels
  • sig/autoscaling sig/gcp: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit a8a5d44 into kubernetes:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawych kawych Awaiting requested review from kawych

@mwielgus mwielgus Awaiting requested review from mwielgus

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@kawych kawych

@gmarek gmarek

@aleksandra-malinowska aleksandra-malinowska

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aleksandra-malinowska @gmarek @kawych @k8s-github-robot @enisoc @k8s-ci-robot