Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-standard, undocumented, unused, or deprecated github labels #57911

Closed
spiffxp opened this issue Jan 5, 2018 · 7 comments
Closed

Remove non-standard, undocumented, unused, or deprecated github labels #57911

spiffxp opened this issue Jan 5, 2018 · 7 comments
Assignees
@spiffxp
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2018 •
edited

This, of course, begs the question of "where are the github labels documented" because they're not, really (#34255)

We have a "standard" subset propagated across all repos at https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.yaml. We could start by documenting those. [This PR](kubernetes/test-infra#2706 was where I tried to get the standard subset ) is the best place I could find for what/why we picked the standard subset that we did. This kubernetes-dev thread was the second best place.

I suspect there are more labels than just the above "standard" labels that should be kept here.

For now, I'm using this as a scratchpad for labels we should just straight up remove from this repo. At kindest, I could drop comments of (open) issues that had these issues prior to removal.

Miscellaneous labels to remove:

Anything that has (deprecated - do not use) in its name:

Labels that we haven't used in quite some time:

Old priority labels can be removed:

/priority important-soon
/kind cleanup
/sig contributor-experience
/assign
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 5, 2018
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2018
This was referenced Jan 5, 2018
Merged
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Mar 12, 2018 •
edited

I did a pass through kubernetes/test-infra/label_sync/labels.yaml recently and will use automation to remove a few of the org-wide labels. Will open a kubernetes/community issue for that.

That said, I think it's time to remove these labels on this repo specifically. E-mail out to kubernetes-dev https://groups.google.com/forum/#!topic/kubernetes-dev/OaoQDfN2gH4

Will move forward in two days if I hear no objections

@cblecker
Copy link
Member

Two comments:

  • the sig-federation -> multicluster should be handled by label_sync as it's org wide
  • do-not-merge is a label that was previously added by someone with write access, while hold is something that anyone (including the PR author) can remove. this isn't a direct translation, and I'd recommend not removing this label at this time.

The rest look fine to me. Although, I'd really like to get a repo-specific label management tool in place.

@jberkus
Copy link

jberkus commented Mar 12, 2018

Aside from @cblecker's comments, LGTM.

@spiffxp
Copy link
Member Author

spiffxp commented Mar 15, 2018

the sig-federation -> multicluster should be handled by label_sync as it's org wide

That was handled by kubernetes/test-infra#6167, there was still detritus left over at some point, but it seems to have been handled at this point

do-not-merge is a label that was previously added by someone with write access, while hold is something that anyone (including the PR author) can remove. this isn't a direct translation, and I'd recommend not removing this label at this time.

Fair point, I'm wondering how many of these still need the label applied such that nobody but people with repo write access can remove, or whether /hold and asking people to behave would be enough. I'll do the rest first and revisit this. At the very least I think it'd be nice to migrate it to prefixed, eg do-not-merge -> do-not-merge/manually-applied or something

@spiffxp
Copy link
Member Author

spiffxp commented Mar 15, 2018 •
edited

Awaiting kubernetes/test-infra#7319. Manual removals below

Miscellaneous labels to remove:

Anything that has (deprecated - do not use) in its name:

Labels that we haven't used in quite some time:

Old priority labels can be removed:

@spiffxp spiffxp mentioned this issue Mar 16, 2018
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Mar 20, 2018

The deleteAfter format was wrong kubernetes/test-infra#7346

Next run should remove labels appropriately

@spiffxp
Copy link
Member Author

spiffxp commented Mar 23, 2018

Labels have been removed. We went from 220 to 178 for this repo. There are 87 in the labels.yaml file used to propagate labels across repos. Where are all the differences coming from, and what could we do next?

$ grep name labels.yaml | sed -e 's/- name: //g' | cut -d/ -f1 | uniq -c | sort -rg
  76 area
  30 sig
  15 kind
   6 size
   6 priority
   6 do-not-merge
   4 queue
   4 milestone
   4 close
   3 status
   3 lifecycle
   2 committee
   1 retest-not-required-docs-only
   1 retest-not-required
   1 release-note-none
   1 release-note-label-needed
   1 release-note-action-required
   1 release-note
   1 release-blocker
   1 needs-sig
   1 needs-rebase
   1 needs-ok-to-test
   1 lgtm
   1 help wanted
   1 cherrypick-candidate
   1 cherrypick-approved
   1 approved
   1 'cncf-cla: yes'
   1 'cncf-cla: no'
   1 'cla: human-approved'
  • Most of the non-standard labels are area/ or kind/ labels. Personally I think that's too much choice, but it would be interesting to see what the data says.
  • The status/ and milestone/ labels aren't "standard", but then, this is the only repo that uses them right now
  • The do-not-merge label I would like to turn into a prefixed label, ie: do-not-merge/manual... that can be done separately

Will open other issues for followup
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spiffxp spiffxp

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spiffxp @jberkus @cblecker @k8s-ci-robot