Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #56622 #58038

Merged
merged 1 commit into from Jan 12, 2018
Merged

Automated cherry pick of #56622 #58038

merged 1 commit into from Jan 12, 2018

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented Jan 10, 2018

Cherry pick of #56622 on release-1.8.

#56622: delete a node from its cache if it gets node not found error

@k8s-ci-robot
Copy link
Contributor

@wackxu: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #56622.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@wackxu: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 10, 2018
@wackxu wackxu mentioned this pull request Jan 10, 2018
Merged
@wackxu
Copy link
Contributor Author

wackxu commented Jan 10, 2018

/assign @bsalamat @davidopp

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Jan 10, 2018 •
edited

Thanks @wackxu.

@bsalamat Can you please approve this backport?

@cblecker
Copy link
Member

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2018
@bsalamat
Copy link
Member

/approve
but I cannot set milestone. @davidopp, could you please add 1.8 milestone?

@bsalamat
Copy link
Member

Oh, looks like OWNER files are picked from the head and after scheduler is moved out of plugin directory, I no longer have approval power for scheduler code in older branches.

@ravisantoshgudimetla
Copy link
Contributor

This may be a problem for all the cherry-picks to scheduler. Can we have owner's file at https://github.com/kubernetes/kubernetes/tree/master/plugin/pkg till we support 1.8? This may not be a problem for other directories as they have owners files. @bsalamat WDYT?

@ravisantoshgudimetla
Copy link
Contributor

LGTMing based on original PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2018
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bsalamat, ravisantoshgudimetla, wackxu

Associated issue: #56622

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bsalamat
Copy link
Member

@ravisantoshgudimetla Hopefully, we won't see many cherrypicks in the future, but if we do and it turns out to be hard to get someone to approve them, we can try to add one or two people to plugin/pkg OWNER file.

@BenTheElder
Copy link
Member

/skip
[Test infra stuff]

@BenTheElder
Copy link
Member

/retest

@BenTheElder
Copy link
Member

/test pull-kubernetes-cross

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 74ced2e into kubernetes:release-1.8 Jan 12, 2018
@bsalamat bsalamat mentioned this pull request Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@davidopp davidopp

@ravisantoshgudimetla ravisantoshgudimetla

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet