Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.9] Automated cherry pick of #57422: Rework method of updating atomic-updated data volumes #58458

Merged
merged 1 commit into from Jan 27, 2018
Merged

[1.9] Automated cherry pick of #57422: Rework method of updating atomic-updated data volumes #58458

merged 1 commit into from Jan 27, 2018

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Jan 18, 2018 •
edited

Cherry pick of #57422 on release-1.9.

#57422: Rework method of updating atomic-updated data volumes

Fixes #60814 for 1.9

@joelsmith
Rework method of updating atomic-updated data volumes
894c499 
This change affects the way that secret, configmap, downwardAPI and projected
volumes (which all use the same underlying code) implement their data update
functionality.

* Instead of creating a subdirectory hierarchy that itself
  will contain symlinks to each actual data file, create only
  symlinks to items in the root of the volume, whether they
  be files or directories.
* Rather than comparing the user-visible data directory
  to see if an update is needed, compare with the current
  version of the data directory.
* Fix data dir timestamp format year
* Create ..data symlink even when a data volume has no data so
  consumers can have simplified update watch logic.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 18, 2018
@joelsmith
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@joelsmith
Copy link
Contributor Author

/assign @jsafrane
/unassign @verult
/unassign @msau42

@k8s-ci-robot k8s-ci-robot assigned jsafrane and unassigned verult and msau42 Jan 18, 2018
@jsafrane jsafrane changed the title Automated cherry pick of #57422: Rework method of updating atomic-updated data volumes [1.9] Automated cherry pick of #57422: Rework method of updating atomic-updated data volumes Jan 18, 2018
@jsafrane
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, jsafrane

Associated issue: #57422

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2018
@joelsmith
Copy link
Contributor Author

/assign @mbohlool

@liggitt liggitt added this to the v1.9 milestone Jan 19, 2018
@joelsmith
Copy link
Contributor Author

/kind bug
/priority important-soon
/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 19, 2018
@sjenning
Copy link
Contributor

@jsafrane can you apply /status approved-for-milestone?

@jsafrane
Copy link
Member

@sjenning, I'd rather not. It's task for 1.9 relase mananager, @mbohlool

@mbohlool
Copy link
Contributor

@joelsmith can you add a more user facing release not to the main PR?

something like:

Fix a bug affecting nested data volumes such as secret, configmap, etc.

@joelsmith
Copy link
Contributor Author

@mbohlool done, thanks for the suggestion.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 27, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed From Pull Request

@joelsmith @jsafrane @mbohlool @kubernetes/sig-node-misc @kubernetes/sig-storage-misc

Important: This pull request was missing the status/approved-for-milestone label for more than 7 days.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Jan 27, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 0ea9f25 into kubernetes:release-1.9 Jan 27, 2018
@joelsmith joelsmith deleted the automated-cherry-pick-of-#57422-upstream-release-1.9 branch February 2, 2018 23:03
@sjenning sjenning mentioned this pull request Feb 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbohlool mbohlool

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@joelsmith @jsafrane @k8s-ci-robot @sjenning @mbohlool @k8s-github-robot @liggitt @verult @msau42