-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use GetUniqueVolumeNameFromSpec instead of implementing it manually for kubelet volume manager #58559
use GetUniqueVolumeNameFromSpec instead of implementing it manually for kubelet volume manager #58559
Conversation
/assign @saad-ali |
/ok-to-test |
/lgtm |
/approve |
/approve no-issue |
/test pull-kubernetes-e2e-kops-aws |
/retest |
1 similar comment
/retest |
@saad-ali |
/retest |
ping @saad-ali |
/retest |
2 similar comments
/retest |
/retest |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mlmhl, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
volumeName
is only used for attachable plugin, so we should resolve it inside theif
statement. Besides, we can use the already existGetUniqueVolumeNameFromSpec
mthod instead of invokingGetVolumeName
andGetUniqueVolumeName
manually.Release note:
/sig storage
/kind cleanup