Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #58574: fixing array out of bound by checking initContainers instead #58885

Merged
merged 1 commit into from Feb 1, 2018
Merged

Automated cherry pick of #58574: fixing array out of bound by checking initContainers instead #58885

merged 1 commit into from Feb 1, 2018

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jan 26, 2018 •
edited by mbohlool

Cherry pick of #58574 on release-1.9.

#58574: fixing array out of bound by checking initContainers instead

Fixes #58541

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 26, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 26, 2018
@dashpole
Copy link
Contributor Author

/assign @mehdy
1.9 patch manager for approval

@k8s-ci-robot
Copy link
Contributor

@dashpole: GitHub didn't allow me to assign the following users: mehdy.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @mehdy
1.9 patch manager for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Contributor Author

/assign @yastij

@k8s-ci-robot
Copy link
Contributor

@dashpole: GitHub didn't allow me to assign the following users: yastij.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @yastij

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Contributor Author

/assign @dchen1107

@yastij
Copy link
Member

yastij commented Jan 26, 2018

@dashpole - thanks for cherry picking this

@mbohlool mbohlool added release-note-none Denotes a PR that doesn't merit a release note. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 26, 2018
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 752a963 into kubernetes:release-1.9 Feb 1, 2018
@dashpole dashpole deleted the automated-cherry-pick-of-#58574-upstream-release-1.9 branch January 15, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij approved these changes

@ncdc ncdc Awaiting requested review from ncdc

@pmorie pmorie Awaiting requested review from pmorie

Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dashpole @k8s-ci-robot @yastij @dchen1107 @k8s-github-robot @mbohlool