Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate-cluster.sh should be using /validate: wants kubectl healthy? #5946

Closed
zmerlynn opened this issue Mar 25, 2015 · 1 comment
Closed

validate-cluster.sh should be using /validate: wants kubectl healthy? #5946

zmerlynn opened this issue Mar 25, 2015 · 1 comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@zmerlynn
Copy link
Member

We have a /validate endpoint that GKE has been using to validate the health of running clusters after the API server is available, similar to the kube-up.sh flow of validate-cluster.sh. There's no reason that validate-cluster.sh should actually do this work manually anymore - we should just go through common source. We should probably introduce a kubectl healthy or kubectl healthcheck?
@zmerlynn zmerlynn mentioned this issue Mar 25, 2015
Closed
@saad-ali saad-ali added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 25, 2015
@fabioy fabioy mentioned this issue Apr 8, 2015
Merged
@fabioy fabioy self-assigned this Apr 9, 2015
@fabioy
Copy link
Contributor

fabioy commented Apr 20, 2015

PR #6597 should have fixed this.

@fabioy fabioy closed this as completed Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zmerlynn @fabioy @saad-ali