Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-gen: output golint compliant 'Generated by' comment #59674

Merged
merged 6 commits into from
Feb 27, 2018
Merged

code-gen: output golint compliant 'Generated by' comment #59674

merged 6 commits into from
Feb 27, 2018

Conversation

jennybuckley
Copy link

@jennybuckley jennybuckley commented Feb 9, 2018 •
edited by sttts

New PR instead of reopening #58115 because /reopen did not work.
This won't be ready to merge until the upstream kubernetes/gengo#94 merges. Once that merges, the second commit will be changed to godep-save.sh and update-staging-godeps.sh, and the last commit will be changed to update-all.sh

The failing test is due to the upstream changes not being merged yet

Go code generated by the code generators will now have a comment which allows them to be easily identified by golint

Fixes #56489

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2018
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 9, 2018
@david-mcmahon david-mcmahon removed their request for review February 14, 2018 19:21
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2018
@fisherxu
Copy link
Contributor

kubernetes/gengo#94 has merged, the work can going on :)

@fisherxu fisherxu mentioned this pull request Feb 23, 2018
Merged
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@thockin
Copy link
Member

thockin commented Feb 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@jennybuckley
Copy link
Author

#60442 merged
/test pull-kubernetes-verify

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@ixdy
Copy link
Member

ixdy commented Feb 27, 2018

/retest

1 similar comment
@ixdy
Copy link
Member

ixdy commented Feb 27, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@jennybuckley: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 27, 2018
@sttts
Copy link
Contributor

sttts commented Feb 27, 2018

Switched the release note to "devel-release-note". This is too much on the development side to be in the generic release notes.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@sttts sttts added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, sttts, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts sttts removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 27, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 1eb1c00 into kubernetes:master Feb 27, 2018
@sttts
Copy link
Contributor

sttts commented Feb 27, 2018

🎉

@sttts sttts mentioned this pull request Feb 27, 2018
Closed
@jennybuckley jennybuckley mentioned this pull request Feb 27, 2018
Open
@neolit123 neolit123 mentioned this pull request Apr 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

@enj enj Awaiting requested review from enj

@erictune erictune Awaiting requested review from erictune

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

@jamiehannaford jamiehannaford Awaiting requested review from jamiehannaford

@jianhuiz jianhuiz Awaiting requested review from jianhuiz

@lavalamp lavalamp Awaiting requested review from lavalamp

@mbohlool mbohlool Awaiting requested review from mbohlool

@pwittrock pwittrock Awaiting requested review from pwittrock

@saad-ali saad-ali Awaiting requested review from saad-ali

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@lavalamp lavalamp

@sttts sttts

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jennybuckley @fisherxu @thockin @sttts @fejta-bot @ixdy @k8s-ci-robot @k8s-github-robot @lavalamp