Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test failure] verify.openapi-spec #59895

Closed
krzyzacy opened this issue Feb 15, 2018 · 9 comments
Closed

[test failure] verify.openapi-spec #59895

krzyzacy opened this issue Feb 15, 2018 · 9 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@krzyzacy
Copy link
Member

@calebamiles looks like you've merged c007efc into master branch? That seems have broken http://k8s-testgrid.appspot.com/google-unit#verify-master and http://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-verify

can you take a look?

/priority failing-test
/assign @calebamiles

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 15, 2018
@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Feb 15, 2018
@krzyzacy
Copy link
Member Author

/sig release
cc @jiayingz

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2018
@krzyzacy krzyzacy added this to the v1.10 milestone Feb 15, 2018
@cblecker
Copy link
Member

This looks to have been resolved, but root cause unknown:
failed: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-master/18553
passed: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-master/18554
same repo commit, different infra commit

@krzyzacy
Copy link
Member Author

I'll leave @calebamiles to close this? I'm not sure the root cause yet, but if that manual merged commit is related, we should probably avoid it in the future.

@calebamiles
Copy link
Contributor

@krzyzacy, I believe that commit was made "automagically" by anago while I was attempting to cut the 1.10 branch. @david-mcmahon noticed other problems and has magically cleaned up after the tool. Will follow up with him and you tomorrow.

@david-mcmahon
Copy link
Contributor

david-mcmahon commented Feb 15, 2018

Root cause was two tags landing on the same commit due to this recent change. Solution was to temporarily remove the -beta tag from that commit so it doesn't interfere with the -alpha tag. master branch is now fine. Still need to tag the branch, but the question is, how given we don't make a change to the branch at branch time. When it gets worked out will update this issue. cc @ixdy @enisoc

@jberkus
Copy link

jberkus commented Feb 19, 2018

adding priority, move to critical if it is

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 19, 2018
@jberkus
Copy link

jberkus commented Feb 21, 2018

adding kind as well, sorry I missed that.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 21, 2018
@jberkus
Copy link

jberkus commented Feb 28, 2018

now critical, since we're in Code Freeze.

/priority critical-urgent
/remove-priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 28, 2018
@krzyzacy
Copy link
Member Author

the test is fixed, we can move discussion to kubernetes/sig-release#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

7 participants