Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gke nvidia-gpu-device-plugin to the latest version that supports #60259

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Update gke nvidia-gpu-device-plugin to the latest version that supports #60259

merged 1 commit into from
Feb 27, 2018

Conversation

jiayingz
Copy link
Contributor

both v1alpha and v1beta1 device plugin versions.
Re-enables nvidia-gpus e2e test after verifying the test passes now.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

@k8s-ci-robot
Copy link
Contributor

@jiayingz: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2018
@jiayingz
Copy link
Contributor Author

/sig-node
/sig-scheduling
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2018
ScorpioCPH
ScorpioCPH approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2018
@jiayingz
Update gke nvidia-gpu-device-plugin to the latest version that supports
9a05af5 
both v1alpha and v1beta1 device plugin versions.
Re-enables nvidia-gpus e2e test after verifying the test passes now.
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@jiayingz
Copy link
Contributor Author

/test pull-kubernetes-verify

rohitagarwal003
rohitagarwal003 approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@rohitagarwal003 rohitagarwal003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@jiayingz
Copy link
Contributor Author

/assign @eparis @jbeda

@eparis
Copy link
Contributor

eparis commented Feb 26, 2018

/approve

@jiayingz
Copy link
Contributor Author

/test pull-kubernetes-e2e-gke

1 similar comment
@jiayingz
Copy link
Contributor Author

/test pull-kubernetes-e2e-gke

@vishh
Copy link
Contributor

vishh commented Feb 27, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, jiayingz, mindprince, ScorpioCPH, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@vishh vishh added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. status/approved-for-milestone and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2018
@vishh vishh added this to the v1.10 milestone Feb 27, 2018
@jiayingz
Copy link
Contributor Author

@eparis thanks a lot for approving the PR. Do you know why the PR still says it doesn't have approved label?

@vishh vishh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5baef69 into kubernetes:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitagarwal003 rohitagarwal003 rohitagarwal003 approved these changes

@ScorpioCPH ScorpioCPH ScorpioCPH approved these changes

@k82cn k82cn k82cn approved these changes

@eparis eparis Awaiting requested review from eparis

Assignees

@jbeda jbeda

@rohitagarwal003 rohitagarwal003

@ScorpioCPH ScorpioCPH

@vishh vishh

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jiayingz @k8s-ci-robot @eparis @vishh @k8s-github-robot @rohitagarwal003 @ScorpioCPH @k82cn @jbeda