Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up elasticsearch from unit test #60365

Merged
merged 1 commit into from Mar 9, 2018
Merged

clean up elasticsearch from unit test #60365

merged 1 commit into from Mar 9, 2018

Conversation

CaoShuFeng
Copy link
Contributor

@CaoShuFeng CaoShuFeng commented Feb 24, 2018 •
edited

The example of elasticsearch has been removed.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 24, 2018
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-unit

1 similar comment
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2018
@CaoShuFeng
Copy link
Contributor Author

/assign @brendandburns

@zouyee
Copy link
Member

zouyee commented Mar 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2018
@zouyee
Copy link
Member

zouyee commented Mar 2, 2018 •
edited

cc @ahmetb

@ahmetb
Copy link
Member

ahmetb commented Mar 2, 2018

/lgtm

@ahmetb
Copy link
Member

ahmetb commented Mar 2, 2018

In fact we can just consider removing examples_test.go altogether. That directory (examples/ is now readonly) you may hit the blockade while merging this PR.

@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

1 similar comment
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@CaoShuFeng CaoShuFeng mentioned this pull request Mar 8, 2018
Closed
@feiskyer feiskyer mentioned this pull request Mar 8, 2018
Closed
@brendandburns
Copy link
Contributor

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, brendandburns, CaoShuFeng, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@CaoShuFeng
Copy link
Contributor Author

@brendandburns
Does this worth 1.10 milestone?
It's a bug fix, I think.

@ixdy
Copy link
Member

ixdy commented Mar 8, 2018

The test was (unintentionally) broken in #59319, which is part of v1.10, so it seems to me like we should target this for v1.10. (It's also just a test fix.)

@ixdy
Copy link
Member

ixdy commented Mar 8, 2018

(We didn't notice this breakage because past-me was lazy (c4455ee), but I'm working on a PR to get this test running again as long as we have examples/ in the repo.)

@dims
Copy link
Member

dims commented Mar 8, 2018

LGTM 👍

@ixdy ixdy mentioned this pull request Mar 8, 2018
Closed
@ixdy
Copy link
Member

ixdy commented Mar 8, 2018

The aforementioned PR to run this test under bazel: #60944

@krzyzacy
Copy link
Member

krzyzacy commented Mar 8, 2018

/milestone v1.10
cc @jdumars

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: The provided milestone is not valid for this repository. Here are the available milestones:
1.clear
1.next-candidate
1.v1.10
1.v1.12
1.v1.6
1.v1.7
1.v1.4
1.v1.5
1.v1.11
1.v1.13
1.v1.8
1.v1.9

In response to this:

/milestone v1.10
cc @jdumars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy krzyzacy added this to the v1.10 milestone Mar 8, 2018
@BenTheElder
Copy link
Member

@cjwagner that looks super wrong, did we deploy the milestone plugin fix? (guess not...)

@krzyzacy
Copy link
Member

krzyzacy commented Mar 8, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 8, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@CaoShuFeng @ahmetb @brendandburns @zouyee

Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone.

priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.
sig owner: Must specify at least one label prefixed with sig/.

Help

@cjwagner
Copy link
Member

cjwagner commented Mar 8, 2018

did we deploy the milestone plugin fix

@BenTheElder We did not. I'll make a bump PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0aad894 into kubernetes:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouyee zouyee zouyee approved these changes

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@ahmetb ahmetb

@brendandburns brendandburns

@zouyee zouyee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. milestone/incomplete-labels release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet