Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regional clusters startup #60422

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix regional clusters startup #60422

merged 1 commit into from
Feb 27, 2018

Conversation

wojtek-t
Copy link
Member

No description provided.

@wojtek-t wojtek-t added this to the v1.10 milestone Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2018
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2018
@wojtek-t wojtek-t mentioned this pull request Feb 26, 2018
Closed
@wojtek-t wojtek-t force-pushed the fix_regional_clusters_startup branch from c63ed73 to 3ca2622 Compare February 26, 2018 13:26
@wojtek-t wojtek-t force-pushed the fix_regional_clusters_startup branch from 3ca2622 to 10e423a Compare February 26, 2018 14:20
@wojtek-t
Copy link
Member Author

/retest

@jpbetz
Copy link
Contributor

jpbetz commented Feb 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5fcc8dd into kubernetes:master Feb 27, 2018
This was referenced Mar 30, 2018
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 3, 2018
Merge pull request #61957 from jpbetz/migrate-if-needed-ha-fix-1.8
e67ae79 
Automatic merge from submit-queue.

Backport etcd.manifest fixes for HA clusters from #61241 to 1.8

Backport the `etcd.manifest` changes from #61241 to kubernetes 1.8. This fixes GCE configurations using HA etcd with k8s.gcr.io/etcd images built from #61241 (k8s.gcr.io/etcd:e.g. 3.1.13-0).

Note: I am not including the #60422 fix to use `host_ip` instead of `hostname` in this backport, which is required for running etcd 3.2+.  We might need that, but I'd like backport it in a separate PR if we do.

```release-note
Fix GCE etcd scripts to pass in all required parameters for the etcd migration utility to correctly perform HA upgrades and downgrades
```
k8s-github-robot pushed a commit that referenced this pull request Apr 9, 2018
Merge pull request #61956 from jpbetz/migrate-if-needed-ha-fix-1.9
9c37699 
Automatic merge from submit-queue.

Backport etcd.manifest fixes for HA clusters from #61241 to 1.9

Backport the `etcd.manifest` changes from #61241 to kubernetes 1.9. This fixes GCE configurations using HA etcd with k8s.gcr.io/etcd images built from #61241 (k8s.gcr.io/etcd:e.g. 3.1.13-0).

Note: I am not including the #60422 fix to use `host_ip` instead of `hostname` in this backport, which is required for running etcd 3.2+.  We might need that, but I'd like backport it in a separate PR if we do.

```release-note
Fix GCE etcd scripts to pass in all required parameters for the etcd migration utility to correctly perform HA upgrades and downgrades
```
@wojtek-t wojtek-t deleted the fix_regional_clusters_startup branch May 17, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wojtek-t @k8s-ci-robot @jpbetz @fejta-bot @k8s-github-robot