Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #58433: bugfix(mount): lstat with abs path of parent instead of '/..' #61194

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Automated cherry pick of #58433: bugfix(mount): lstat with abs path of parent instead of '/..' #61194

merged 1 commit into from
Mar 15, 2018

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Mar 14, 2018 •
edited by liggitt

Cherry pick of #58433 on release-1.8.

#58433: bugfix(mount): lstat with abs path of parent instead of '/..'

Fix a regression that prevented cleanup of a `subPath` volume mount

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 14, 2018
@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/kind bug
/sig storage
/priority critical-urgent
/assign @msau42
/status approved-for-milestone
/milestone v1.8

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Mar 14, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 14, 2018
@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/retest

1 similar comment
@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/retest

@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jpbetz @jsafrane @liggitt @msau42

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 14, 2018
@Silvenga Silvenga mentioned this pull request Mar 14, 2018
Closed
4 tasks
@Joseph-Irving Joseph-Irving mentioned this pull request Mar 14, 2018
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 14, 2018
@liggitt
Copy link
Member

liggitt commented Mar 14, 2018

/retest

1 similar comment
@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 64d864f into kubernetes:release-1.8 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jpbetz jpbetz

@liggitt liggitt

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jsafrane @liggitt @k8s-ci-robot @k8s-github-robot @jpbetz @msau42 @yue9944882