New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory #61519
Conversation
/assign @saad-ali @tallclair |
/hold |
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process @jpbetz @mbohlool @msau42 @saad-ali @tallclair Pull Request Labels
|
8d0f0b2
to
542eec1
Compare
Without the reconstruction refactoring in 1.10, there are many more volume types where reconstruction doesn't work in general in 1.9. I'm running the tests now to see which ones fail, verify that it is expected reconstruction should fail for them, and then disable the tests for those volume types. |
542eec1
to
6402924
Compare
Finally worked out the 1.9 reconstruction issues. For the 1.9 backport, I had to: |
/hold cancel |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, saad-ali, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Cherry pick of #61373 on release-1.9.
#61373: Use inner volume name instead of outer volume name for subpath directory
Release note: