Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory #61519

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Mar 22, 2018

Cherry pick of #61373 on release-1.9.

#61373: Use inner volume name instead of outer volume name for subpath directory

Release note:

ACTION REQUIRED: In-place node upgrades to this release from versions 1.7.14, 1.8.9, and 1.9.4 are not supported if using subpath volumes with PVCs.  Such pods should be drained from the node first.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 22, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 22, 2018
@msau42
Copy link
Member Author

msau42 commented Mar 22, 2018

/assign @saad-ali @tallclair

@msau42
Copy link
Member Author

msau42 commented Mar 22, 2018

/hold
need to run e2es first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2018
@liggitt liggitt changed the title Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory [1.9] Automated cherry pick of #61373: Use inner volume name instead of outer volume name for subpath directory Mar 22, 2018
@liggitt
Copy link
Member

liggitt commented Mar 22, 2018

/kind bug
/priority critical-urgent
/status approved-for-milestone
/sig storage
/milestone v1.9
/assign @jpbetz @mbohlool

@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Mar 22, 2018
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 22, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@jpbetz @mbohlool @msau42 @saad-ali @tallclair

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 22, 2018
@msau42 msau42 force-pushed the automated-cherry-pick-of-#61373-upstream-release-1.9 branch from 8d0f0b2 to 542eec1 Compare March 22, 2018 18:43
@msau42
Copy link
Member Author

msau42 commented Mar 22, 2018

Without the reconstruction refactoring in 1.10, there are many more volume types where reconstruction doesn't work in general in 1.9. I'm running the tests now to see which ones fail, verify that it is expected reconstruction should fail for them, and then disable the tests for those volume types.

@msau42 msau42 force-pushed the automated-cherry-pick-of-#61373-upstream-release-1.9 branch from 542eec1 to 6402924 Compare March 23, 2018 01:08
@msau42
Copy link
Member Author

msau42 commented Mar 23, 2018

Finally worked out the 1.9 reconstruction issues. For the 1.9 backport, I had to:

  • Increase timeout after force deletion of pod to 4 minutes. It seems like kubelet reconstruction doesn't kick in until 3 minutes after kubelet starts. @jingxu97
  • Add gluster to the list of volumes where reconstruction fails. @gnufied

@msau42
Copy link
Member Author

msau42 commented Mar 23, 2018

/hold cancel
ran all the subpath e2es, and they are passing

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2018
@tallclair
Copy link
Member

/approve

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saad-ali, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Mar 23, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit d3099c7 into kubernetes:release-1.9 Mar 24, 2018
@msau42 msau42 deleted the automated-cherry-pick-of-#61373-upstream-release-1.9 branch November 17, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants