Automated cherry pick of #61480: Use O_PATH to avoid errors on Openat #61722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests for sockets and fifos Replace use of syscall for flags with unix
k8s-ci-robot
added
size/M
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
jpbetz
added
cherry-pick-approved
This was referenced Mar 27, 2018
k8s-ci-robot
added
size/L
gnufied
force-pushed
the
automated-cherry-pick-of-#61480-upstream-release-1.9
branch
from
05b07ee
to
46a2460
Compare
msau42
reviewed
Mar 28, 2018
pkg/util/mount/mount_linux_test.go
Outdated
| @@ -1395,6 +1462,15 @@ func TestSafeOpen(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatalf(err.Error()) | |||
| } | |||
|
|
|||
| // If base path is too long, creation of unix sockets will fail. | |||
| if len(base) > 75 { | |||
There was a problem hiding this comment.
No I don't. I am waiting for master PR to get merged, I will simply cherry-pick that one verbatim rather than creating new commit.
|
/assign |
gnufied
force-pushed
the
automated-cherry-pick-of-#61480-upstream-release-1.9
branch
from
46a2460
to
b6ab1e2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, msau42, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
saad-ali
added
kind/bug
|
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process Pull Request Labels
|
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #61480 on release-1.9.
#61480: Use O_PATH to avoid errors on Openat
Also cherry-pick #61842 to avoid test failures because of long socket paths.